From: Andrew Morton <akpm@linux-foundation.org>
To: Matthew Wilcox <matthew@wil.cx>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Matthew Wilcox <willy@linux.intel.com>
Subject: Re: [PATCH 1/4] stringbuf: A string buffer implementation
Date: Tue, 23 Oct 2007 19:45:27 -0700 [thread overview]
Message-ID: <20071023194527.4ac1dc85.akpm@linux-foundation.org> (raw)
In-Reply-To: <20071024023035.GV27248@parisc-linux.org>
On Tue, 23 Oct 2007 20:30:35 -0600 Matthew Wilcox <matthew@wil.cx> wrote:
> It's a matter of taste ... some people prefer to use accessors for
> everything, other people prefer to expose the underlying structure
> directly.
Experience tells us that when you use accessors you end up thanking
yourself later on. Especially when diddling struct page ;)
Although one really should make a best-effort guess at "how likely is
this to change in the future". If the implementation-to-be-copied
has been out there for a while then "not very" is a good answer.
But hey, don't listen to me - I like C++, and approve of Java.
next prev parent reply other threads:[~2007-10-24 2:45 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-23 21:12 [PATCH 1/4] stringbuf: A string buffer implementation Matthew Wilcox
2007-10-23 21:12 ` [PATCH 2/4] isdn: Use stringbuf Matthew Wilcox
2007-10-23 21:12 ` [PATCH 3/4] sound: " Matthew Wilcox
2007-10-23 21:12 ` [PATCH 4/4] partitions: Fix non-atomic printk Matthew Wilcox
2007-10-24 14:18 ` [PATCH 3/4] sound: Use stringbuf Takashi Iwai
2007-10-24 16:01 ` Matthew Wilcox
2007-10-24 14:50 ` Takashi Iwai
2007-10-23 22:11 ` [PATCH 1/4] stringbuf: A string buffer implementation Matt Mackall
2007-10-24 1:49 ` Matthew Wilcox
2007-10-24 15:20 ` Matt Mackall
2007-10-24 15:30 ` Matthew Wilcox
2007-10-23 23:43 ` Linus Torvalds
2007-10-24 2:30 ` Matthew Wilcox
2007-10-24 2:45 ` Andrew Morton [this message]
2007-10-24 2:19 ` Eric St-Laurent
2007-10-24 2:35 ` Matthew Wilcox
2007-10-24 2:48 ` Eric St-Laurent
2007-10-24 13:21 ` Florian Weimer
2007-10-24 14:02 ` Matthew Wilcox
2007-10-26 12:05 ` Pekka Enberg
2007-10-27 7:31 ` Pavel Machek
2007-10-30 15:26 ` Denys Vlasenko
-- strict thread matches above, loose matches on Subject: below --
2007-10-24 19:58 Stringbuf, v2 Matthew Wilcox
2007-10-24 19:59 ` [PATCH 1/4] stringbuf: A string buffer implementation Matthew Wilcox
2007-10-24 20:59 ` Kyle Moffett
2007-10-24 21:21 ` Matthew Wilcox
2007-10-25 0:07 ` Kyle Moffett
2007-10-25 3:23 ` Matthew Wilcox
2007-10-26 2:11 ` Rusty Russell
2007-10-26 3:41 ` Joe Perches
2007-10-26 5:05 ` Joe Perches
2007-10-26 11:57 ` Matthew Wilcox
2007-10-26 20:57 ` Matt Mackall
2007-10-27 10:09 ` Rusty Russell
2007-10-29 3:03 ` Matt Mackall
2007-10-29 5:38 ` Rusty Russell
2007-10-27 11:47 ` Pekka Enberg
2007-10-27 12:50 ` Rusty Russell
2007-10-27 16:34 ` Pekka Enberg
2007-10-27 16:48 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071023194527.4ac1dc85.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=torvalds@linux-foundation.org \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox