Re: [RFC] what the hell is going on with /proc/self?

Al Viro
2007-10-23T20:42:32Z

On Tue, Oct 23, 2007 at 03:20:39PM -0500, Matt Mackall wrote:
> On Tue, Oct 23, 2007 at 03:03:36AM +0100, Al Viro wrote:
> > What is the proc_base_stuff[] nonsense about? AFAICS, that
> > went in with no reason whatsoever in
> > commit 801199ce805a2412bbcd9bfe213092ec656013dd
> > Author: Eric W. Biederman <ebiederm@xmission.com>
> > Date: Mon Oct 2 02:18:48 2006 -0700
> >
> > Rationale is very weak and patch adds considerable complexity
> > for no good reason. Besides, it's obfuscated just for the hell of it:
> > if (!IS_ERR(result) || PTR_ERR(result) != -ENOENT)
> > instead of
> > if (result != ERR_PTR(-ENOENT))
> > etc.
> >
> > Unless there are _real_ plans that would justify that animal,
> > I'm going to get rid of it in the pending patch series (/proc/self
> > cleanups, saner dentry retention for non-process parts, etc.).
>
> Seems obvious to cc: Eric.

Doh... Sorry, thought I'd done that. Eric, my apologies.