From: Christoph Hellwig <hch@infradead.org>
To: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: thomas.mingarelli@hp.com, linux-kernel@vger.kernel.org,
Wim Van Sebroeck <wim@iguana.be>
Subject: Re: [HP ProLiant WatchDog driver] hpwdt HP WatchDog Patch <resend>
Date: Tue, 23 Oct 2007 22:20:32 +0100 [thread overview]
Message-ID: <20071023212032.GA26597@infradead.org> (raw)
In-Reply-To: <200710231431.15267.bjorn.helgaas@hp.com>
On Tue, Oct 23, 2007 at 02:31:15PM -0600, Bjorn Helgaas wrote:
> The driver assumes only a single instance of the device. But PCI being
> what it is, it's often possible to have multiple cards, so you might
> want some protection in case you trip over more than one.
Yes. And even with that protection please move all the global variables
into some per-device structure. That makes the code a lot more understandable
and future-proof in case multiple devices of this type may appear somewhere.
next prev parent reply other threads:[~2007-10-23 21:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-22 23:09 [HP ProLiant WatchDog driver] hpwdt HP WatchDog Patch <resend> thomas.mingarelli
2007-10-23 20:31 ` Bjorn Helgaas
2007-10-23 21:20 ` Christoph Hellwig [this message]
2007-10-23 23:04 ` Mingarelli, Thomas
2007-10-24 14:16 ` Mingarelli, Thomas
2007-10-24 16:25 ` Wim Van Sebroeck
-- strict thread matches above, loose matches on Subject: below --
2007-10-24 18:52 thomas.mingarelli
2007-11-04 19:11 ` Wim Van Sebroeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071023212032.GA26597@infradead.org \
--to=hch@infradead.org \
--cc=bjorn.helgaas@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas.mingarelli@hp.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox