Re: [PATCH 3/4] sound: Use stringbuf

Takashi Iwai
2007-10-24T16:20:45Z

At Wed, 24 Oct 2007 10:01:05 -0600,
Matthew Wilcox wrote:
>
> > Any other bugs I missed?
>
> Let me try to find them ... there was this warning fix:
>
> diff --git a/sound/isa/ad1848/ad1848_lib.c b/sound/isa/ad1848/ad1848_lib.c
> index a901cd1..9a64035 100644
> --- a/sound/isa/ad1848/ad1848_lib.c
> +++ b/sound/isa/ad1848/ad1848_lib.c
> @@ -213,7 +213,7 @@ static void snd_ad1848_mce_down(struct snd_ad1848 *chip)
> for (timeout = 12000; timeout > 0 && (inb(AD1848P(chip, REGSEL)) & AD184
> 8_INIT); timeout--)
> udelay(100);
>
> - snd_printdd("(1) timeout = %d\n", timeout);
> + snd_printdd("(1) timeout = %ld\n", timeout);
>
> #ifdef CONFIG_SND_DEBUG
> if (inb(AD1848P(chip, REGSEL)) & AD1848_INIT)
>
> but I think that's the only one.

OK, thanks. I fixed it on ALSA tree now.

Takashi