Re: [PATCH 1/4] stringbuf: A string buffer implementation

Matthew Wilcox
2007-10-24T15:30:56Z

On Wed, Oct 24, 2007 at 10:20:36AM -0500, Matt Mackall wrote:
> On Tue, Oct 23, 2007 at 07:49:20PM -0600, Matthew Wilcox wrote:
> > I presume slob is different? Actually, slob doesn't seem to
> > provide krealloc, so I think stringbuf won't work on slob. Will you
> > have time to fix this?
>
> http://lxr.linux.no/source/mm/slob.c#L207

That's 2.6.22.6; I was looking at 2.6.23, where clameter had moved
krealloc into mm/util.c. So that explains why I thought slob didn't
provide it. Apologies for the confusion.

> Yep, slob is different, it has no kmalloc buckets.

OK. I have no problem with making stringbuf allocate max(oldsize * 1.5,
newsize+1).

> > extern void sb_printf(struct stringbuf *sb, gfp_t gfp, const char *fmt, ...)
> > __attribute__((format(printf, 3, 4)));
> >
> > ? Any objections?
>
> Fine by me.

OK, I'll do that for the next round of patches.

> Most of these objects will have very short lifetimes, so there's very
> little downside.

I agree. It was good for testing though, when I inadvertently wrote to
the wrong bit of the string on a realloc ;-)

--
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."