public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Jeff Garzik <jeff@garzik.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>,
	"Frank Ch. Eigler" <fche@redhat.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [RFC/git patch] move samples/ to Documentation/markers/
Date: Wed, 24 Oct 2007 12:10:58 +0200	[thread overview]
Message-ID: <20071024101058.GA450@uranus.ravnborg.org> (raw)
In-Reply-To: <20071024095226.GA30326@havoc.gtf.org>

Hi Jeff.

Why do you think it is not worthwhile to build the samples so we can check that they
are to some extend valid code?

I noticed you deleted the following - but you did not explain why.

	Sam

Makefile b/Makefile
> index 2a47290..83894ae 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -774,9 +774,6 @@ vmlinux: $(vmlinux-lds) $(vmlinux-init) $(vmlinux-main) $(kallsyms.o) vmlinux.o
>  ifdef CONFIG_HEADERS_CHECK
>  	$(Q)$(MAKE) -f $(srctree)/Makefile headers_check
>  endif
> -ifdef CONFIG_SAMPLES
> -	$(Q)$(MAKE) $(build)=samples
> -endif
>  	$(call vmlinux-modpost)
>  	$(call if_changed_rule,vmlinux__)
>  	$(Q)rm -f .old_version

  reply	other threads:[~2007-10-24 10:09 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-24  9:52 [RFC/git patch] move samples/ to Documentation/markers/ Jeff Garzik
2007-10-24 10:10 ` Sam Ravnborg [this message]
2007-10-24 13:05 ` Mathieu Desnoyers
2007-10-24 13:19   ` Jeff Garzik
2007-10-24 16:12     ` Randy Dunlap
2007-10-24 16:17       ` Sam Ravnborg
2007-10-24 17:31       ` [RFC] create instrumentation/ directory Mathieu Desnoyers
2007-10-24 17:48         ` Randy Dunlap
2007-10-25 20:08         ` Valdis.Kletnieks

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071024101058.GA450@uranus.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=akpm@linux-foundation.org \
    --cc=fche@redhat.com \
    --cc=jeff@garzik.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@polymtl.ca \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox