From: Paul Jackson <pj@sgi.com>
To: "Paul Menage" <menage@google.com>
Cc: bunk@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] kernel/cgroup.c: remove dead code
Date: Wed, 24 Oct 2007 10:34:11 -0700 [thread overview]
Message-ID: <20071024103411.dfd3ae04.pj@sgi.com> (raw)
In-Reply-To: <6599ad830710240930r6649dec0q21b8c00f7d8a796a@mail.gmail.com>
Paul M wrote:
> I think I'd rather not make this change - if we later changed the size
> of release_agent_path[] this could silently fail. Can we get around
> the coverity checker somehow?
Perhaps we can simplify this check then, to:
BUG_ON(sizeof(cgrp->root->release_agent_path) < PATH_MAX));
Less runtime code.
This patch of Adrian highlighted a couple more opportunities
for code tweaking ... see my RFC patches, coming next from me.
--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@sgi.com> 1.925.600.0401
next prev parent reply other threads:[~2007-10-24 17:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-24 16:25 [2.6 patch] kernel/cgroup.c: remove dead code Adrian Bunk
2007-10-24 16:30 ` Paul Menage
2007-10-24 17:07 ` Adrian Bunk
2007-10-24 17:13 ` Paul Menage
2007-10-24 17:34 ` Paul Jackson [this message]
2007-10-26 1:10 ` Paul Menage
2007-10-26 1:19 ` Adrian Bunk
2007-10-26 1:24 ` Paul Jackson
2007-10-26 1:26 ` Paul Menage
2007-10-26 1:37 ` Paul Jackson
2007-10-26 1:30 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071024103411.dfd3ae04.pj@sgi.com \
--to=pj@sgi.com \
--cc=bunk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=menage@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox