* [PATCH] Bogus KERN_ALERT on oops
@ 2007-10-22 11:57 Alexey Dobriyan
2007-10-22 13:06 ` Pekka Enberg
2007-10-24 10:32 ` Ingo Molnar
0 siblings, 2 replies; 5+ messages in thread
From: Alexey Dobriyan @ 2007-10-22 11:57 UTC (permalink / raw)
To: akpm; +Cc: linux-kernel, devel
printing eip: f881b9f3 *pdpt = 0000000000003001 <1>*pde = 000000000480a067 *pte = 0000000000000000
^^^
Signed-off-by: Alexey Dobriyan <adobriyan@sw.ru>
---
arch/x86/mm/fault_32.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/arch/x86/mm/fault_32.c
+++ b/arch/x86/mm/fault_32.c
@@ -550,7 +550,7 @@ no_context:
page &= PAGE_MASK;
page = ((__typeof__(page) *) __va(page))[(address >> PMD_SHIFT)
& (PTRS_PER_PMD - 1)];
- printk(KERN_ALERT "*pde = %016Lx ", page);
+ printk("*pde = %016Lx ", page);
page &= ~_PAGE_NX;
}
#else
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] Bogus KERN_ALERT on oops
2007-10-22 11:57 [PATCH] Bogus KERN_ALERT on oops Alexey Dobriyan
@ 2007-10-22 13:06 ` Pekka Enberg
2007-10-24 10:33 ` Ingo Molnar
2007-10-24 10:32 ` Ingo Molnar
1 sibling, 1 reply; 5+ messages in thread
From: Pekka Enberg @ 2007-10-22 13:06 UTC (permalink / raw)
To: Alexey Dobriyan; +Cc: akpm, linux-kernel, devel
Hi Alexey,
On 10/22/07, Alexey Dobriyan <adobriyan@sw.ru> wrote:
> printing eip: f881b9f3 *pdpt = 0000000000003001 <1>*pde = 000000000480a067 *pte = 0000000000000000
> --- a/arch/x86/mm/fault_32.c
> +++ b/arch/x86/mm/fault_32.c
> @@ -550,7 +550,7 @@ no_context:
> page &= PAGE_MASK;
> page = ((__typeof__(page) *) __va(page))[(address >> PMD_SHIFT)
> & (PTRS_PER_PMD - 1)];
> - printk(KERN_ALERT "*pde = %016Lx ", page);
> + printk("*pde = %016Lx ", page);
Use the new KERN_CONT annotation here?
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] Bogus KERN_ALERT on oops
2007-10-22 13:06 ` Pekka Enberg
@ 2007-10-24 10:33 ` Ingo Molnar
2007-10-24 11:39 ` Alexey Dobriyan
0 siblings, 1 reply; 5+ messages in thread
From: Ingo Molnar @ 2007-10-24 10:33 UTC (permalink / raw)
To: Pekka Enberg; +Cc: Alexey Dobriyan, akpm, linux-kernel, devel
* Pekka Enberg <penberg@cs.helsinki.fi> wrote:
> > - printk(KERN_ALERT "*pde = %016Lx ", page);
> > + printk("*pde = %016Lx ", page);
>
> Use the new KERN_CONT annotation here?
indeed - i changed the patch to do that.
Ingo
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] Bogus KERN_ALERT on oops
2007-10-24 10:33 ` Ingo Molnar
@ 2007-10-24 11:39 ` Alexey Dobriyan
0 siblings, 0 replies; 5+ messages in thread
From: Alexey Dobriyan @ 2007-10-24 11:39 UTC (permalink / raw)
To: Ingo Molnar; +Cc: Pekka Enberg, akpm, linux-kernel, devel
On Wed, Oct 24, 2007 at 12:33:18PM +0200, Ingo Molnar wrote:
>
> * Pekka Enberg <penberg@cs.helsinki.fi> wrote:
>
> > > - printk(KERN_ALERT "*pde = %016Lx ", page);
> > > + printk("*pde = %016Lx ", page);
> >
> > Use the new KERN_CONT annotation here?
>
> indeed - i changed the patch to do that.
Might as well change comment around KERN_CONT -- for starters it lied
about "early bootup" phase since day one.
Proposed text:
/*
* Annotation for a "continued" line of log printout (only done
* after a line that had no enclosing \n).
*
* Introduced because checkpatch.pl couldn't be arsed to learn C
* and distinguish continued printk() from the one that starts
* new line.
*
* Caveat #1: Empty string-literal, so compiler can't check for
* KERN_CONT misuse.
* Caveat #2: Empty string-literal, so it can't be used in
* printk(var); situations.
* Caveat #3: takes characters on the screen, so code is harder
* to read.
* Caveat #4: checkpatch.pl doesn't know C, so it can't check
* for KERN_CONT misuse, anyway.
*/
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Bogus KERN_ALERT on oops
2007-10-22 11:57 [PATCH] Bogus KERN_ALERT on oops Alexey Dobriyan
2007-10-22 13:06 ` Pekka Enberg
@ 2007-10-24 10:32 ` Ingo Molnar
1 sibling, 0 replies; 5+ messages in thread
From: Ingo Molnar @ 2007-10-24 10:32 UTC (permalink / raw)
To: Alexey Dobriyan; +Cc: akpm, linux-kernel, devel
* Alexey Dobriyan <adobriyan@sw.ru> wrote:
> printing eip: f881b9f3 *pdpt = 0000000000003001 <1>*pde = 000000000480a067 *pte = 0000000000000000
> ^^^
thanks, added this to the x86 queue.
Ingo
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2007-10-24 11:40 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-22 11:57 [PATCH] Bogus KERN_ALERT on oops Alexey Dobriyan
2007-10-22 13:06 ` Pekka Enberg
2007-10-24 10:33 ` Ingo Molnar
2007-10-24 11:39 ` Alexey Dobriyan
2007-10-24 10:32 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox