From: Riku Voipio <riku.voipio@iki.fi>
To: Jean Delvare <khali@linux-fr.org>
Cc: "Mark M. Hoffman" <mhoffman@lightlink.com>,
Adrian Bunk <bunk@kernel.org>,
linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org
Subject: Re: [lm-sensors] hwmon/f75375s.c: buggy if()
Date: Wed, 24 Oct 2007 14:50:34 +0300 [thread overview]
Message-ID: <20071024115034.GA5797@kos.to> (raw)
In-Reply-To: <20071019143754.0aa4483b@hyperion.delvare>
On Fri, Oct 19, 2007 at 02:37:54PM +0200, Jean Delvare wrote:
> Riku, can you please submit a patch fixing this? The attribute should
> be declared read-only, and then you can use sysfs_chmod_file() to
> change it to read-write where supported.
Thanks, this was good suggestion. Patch attached.
> Take a look at the w83781d
> driver for an example.
Btw, I think your example code has a indentation bug:
if (kind != w83781d)
err = sysfs_chmod_file(&dev->kobj,
&sensor_dev_attr_temp3_alarm.dev_attr.attr,
S_IRUGO | S_IWUSR);
if (err)
return err;
--
"rm -rf" only sounds scary if you don't have backups
next prev parent reply other threads:[~2007-10-24 11:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-17 19:54 hwmon/f75375s.c: buggy if() Adrian Bunk
2007-10-17 20:45 ` Riku Voipio
2007-10-18 13:37 ` Mark M. Hoffman
2007-10-19 12:37 ` [lm-sensors] " Jean Delvare
2007-10-24 11:50 ` Riku Voipio [this message]
2007-10-25 2:25 ` Mark M. Hoffman
2007-10-25 11:48 ` Riku Voipio
2007-10-26 8:36 ` Jean Delvare
2007-10-26 11:14 ` Riku Voipio
2007-10-26 21:15 ` Jean Delvare
2007-10-28 17:33 ` Mark M. Hoffman
2007-10-25 11:09 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071024115034.GA5797@kos.to \
--to=riku.voipio@iki.fi \
--cc=bunk@kernel.org \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=mhoffman@lightlink.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox