* [2.6 patch] fs/proc/proc_net.c: make a struct static
@ 2007-10-24 16:23 Adrian Bunk
2007-10-24 18:18 ` Eric W. Biederman
0 siblings, 1 reply; 3+ messages in thread
From: Adrian Bunk @ 2007-10-24 16:23 UTC (permalink / raw)
To: Eric Biederman, David S. Miller; +Cc: linux-kernel
Struct proc_net_ns_ops can become static.
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
5ae49d45bc25eed356ecbe3592db270bfa1d9b73
diff --git a/fs/proc/proc_net.c b/fs/proc/proc_net.c
index 2e91fb7..4edaad0 100644
--- a/fs/proc/proc_net.c
+++ b/fs/proc/proc_net.c
@@ -185,7 +185,7 @@ static __net_exit void proc_net_ns_exit(struct net *net)
kfree(net->proc_net_root);
}
-struct pernet_operations __net_initdata proc_net_ns_ops = {
+static struct pernet_operations __net_initdata proc_net_ns_ops = {
.init = proc_net_ns_init,
.exit = proc_net_ns_exit,
};
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [2.6 patch] fs/proc/proc_net.c: make a struct static
2007-10-24 16:23 [2.6 patch] fs/proc/proc_net.c: make a struct static Adrian Bunk
@ 2007-10-24 18:18 ` Eric W. Biederman
2007-10-26 10:55 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Eric W. Biederman @ 2007-10-24 18:18 UTC (permalink / raw)
To: Adrian Bunk; +Cc: David S. Miller, linux-kernel
Adrian Bunk <bunk@kernel.org> writes:
> Struct proc_net_ns_ops can become static.
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
Acked-by: "Eric W. Biederman" <ebiederm@xmission.com>
Don't have a clue why I didn't make it static originally.
> ---
> 5ae49d45bc25eed356ecbe3592db270bfa1d9b73
> diff --git a/fs/proc/proc_net.c b/fs/proc/proc_net.c
> index 2e91fb7..4edaad0 100644
> --- a/fs/proc/proc_net.c
> +++ b/fs/proc/proc_net.c
> @@ -185,7 +185,7 @@ static __net_exit void proc_net_ns_exit(struct net *net)
> kfree(net->proc_net_root);
> }
>
> -struct pernet_operations __net_initdata proc_net_ns_ops = {
> +static struct pernet_operations __net_initdata proc_net_ns_ops = {
> .init = proc_net_ns_init,
> .exit = proc_net_ns_exit,
> };
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [2.6 patch] fs/proc/proc_net.c: make a struct static
2007-10-24 18:18 ` Eric W. Biederman
@ 2007-10-26 10:55 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2007-10-26 10:55 UTC (permalink / raw)
To: ebiederm; +Cc: bunk, linux-kernel
From: ebiederm@xmission.com (Eric W. Biederman)
Date: Wed, 24 Oct 2007 12:18:22 -0600
> Adrian Bunk <bunk@kernel.org> writes:
>
> > Struct proc_net_ns_ops can become static.
> >
> > Signed-off-by: Adrian Bunk <bunk@kernel.org>
>
> Acked-by: "Eric W. Biederman" <ebiederm@xmission.com>
Applied, thanks everyone.
> Don't have a clue why I didn't make it static originally.
:-)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-10-26 10:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-24 16:23 [2.6 patch] fs/proc/proc_net.c: make a struct static Adrian Bunk
2007-10-24 18:18 ` Eric W. Biederman
2007-10-26 10:55 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox