From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763081AbXJXQiu (ORCPT ); Wed, 24 Oct 2007 12:38:50 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758028AbXJXQYr (ORCPT ); Wed, 24 Oct 2007 12:24:47 -0400 Received: from emailhub.stusta.mhn.de ([141.84.69.5]:60943 "EHLO mailhub.stusta.mhn.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1759807AbXJXQYp (ORCPT ); Wed, 24 Oct 2007 12:24:45 -0400 Date: Wed, 24 Oct 2007 18:25:15 +0200 From: Adrian Bunk To: yokota@netlab.is.tsukuba.ac.jp, James.Bottomley@SteelEye.com Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [RFC: 2.6 patch] nsp32_restart_autoscsi(): remove error check Message-ID: <20071024162515.GV30533@stusta.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline User-Agent: Mutt/1.5.16 (2007-06-11) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org The Coverity checker noted that we'll anyway Oops later when we ran into this condition - and the error check didn't prevent that. Considering that the error condition shouldn't be possible, and we are not able to handle it easily, this patch simply removes the pointless error check. Signed-off-by: Adrian Bunk --- This patch has been sent on: - 23 Jul 2007 drivers/scsi/nsp32.c | 4 ---- 1 file changed, 4 deletions(-) --- linux-2.6.22-rc6-mm1/drivers/scsi/nsp32.c.old 2007-07-23 19:38:58.000000000 +0200 +++ linux-2.6.22-rc6-mm1/drivers/scsi/nsp32.c 2007-07-23 20:17:14.000000000 +0200 @@ -1888,44 +1888,40 @@ static void nsp32_msgout_occur(struct sc data->msgout_len = 0; nsp32_dbg(NSP32_DEBUG_MSGOUTOCCUR, "exit"); } /* * Restart AutoSCSI * * Note: Restarting AutoSCSI needs set: * SYNC_REG, ACK_WIDTH, SGT_ADR, TRANSFER_CONTROL */ static void nsp32_restart_autoscsi(struct scsi_cmnd *SCpnt, unsigned short command) { nsp32_hw_data *data = (nsp32_hw_data *)SCpnt->device->host->hostdata; unsigned int base = data->BaseAddress; unsigned short transfer = 0; nsp32_dbg(NSP32_DEBUG_RESTART, "enter"); - if (data->cur_target == NULL || data->cur_lunt == NULL) { - nsp32_msg(KERN_ERR, "Target or Lun is invalid"); - } - /* * set SYNC_REG * Don't set BM_START_ADR before setting this register. */ nsp32_write1(base, SYNC_REG, data->cur_target->syncreg); /* * set ACKWIDTH */ nsp32_write1(base, ACK_WIDTH, data->cur_target->ackwidth); /* * set SREQ hazard killer sampling rate */ nsp32_write1(base, SREQ_SMPL_RATE, data->cur_target->sample_reg); /* * set SGT ADDR (physical address) */ nsp32_write4(base, SGT_ADR, data->cur_lunt->sglun_paddr);