From: Adrian Bunk <bunk@kernel.org>
To: Russell King <rmk+lkml@arm.linux.org.uk>
Cc: Thomas Gleixner <tglx@linutronix.de>,
davej@codemonkey.org.uk, cpufreq@lists.linux.org.uk,
linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] #if 0 cpufreq.c:cpufreq_get()
Date: Wed, 24 Oct 2007 18:46:16 +0200 [thread overview]
Message-ID: <20071024164616.GY30533@stusta.de> (raw)
In-Reply-To: <20071024163245.GF32333@flint.arm.linux.org.uk>
On Wed, Oct 24, 2007 at 05:32:45PM +0100, Russell King wrote:
> On Wed, Oct 24, 2007 at 06:23:12PM +0200, Adrian Bunk wrote:
> > cpufreq.c:cpufreq_get() no longer has any user.
>
> Your checking seems to be flawed.
>
> drivers/video/sa1100fb.c: cpufreq_get(smp_processor_id()));
> drivers/video/sa1100fb.c: pcd = get_pcd(var->pixclock, cpufreq_get(0));
Thanks for spotting this.
My mistake was that I thought this was handled by the following without
checking closer:
arch/arm/mach-sa1100/generic.c:unsigned int cpufreq_get(unsigned int cpu)
arch/arm/mach-sa1100/generic.c:EXPORT_SYMBOL(cpufreq_get);
> Russell King
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2007-10-24 16:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-24 16:23 [2.6 patch] #if 0 cpufreq.c:cpufreq_get() Adrian Bunk
2007-10-24 16:32 ` Russell King
2007-10-24 16:46 ` Adrian Bunk [this message]
2007-10-24 16:38 ` Arjan van de Ven
2007-10-24 17:17 ` Russell King
2007-10-24 18:39 ` Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071024164616.GY30533@stusta.de \
--to=bunk@kernel.org \
--cc=cpufreq@lists.linux.org.uk \
--cc=davej@codemonkey.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk+lkml@arm.linux.org.uk \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox