[patch 1/3] MBCS: Convert algolock to mutex

public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed

* [patch 1/3] MBCS: Convert algolock to mutex
       [not found] <20071024170049.949862374@gmail.com>
@ 2007-10-24 17:09 ` matthias.kaehlcke
  2007-10-24 17:09 ` [patch 2/3] MBCS: Convert dmawritelock " matthias.kaehlcke
  2007-10-24 17:09 ` [patch 3/3] MBCS: Convert dmareadlock " matthias.kaehlcke
  2 siblings, 0 replies; 3+ messages in thread
From: matthias.kaehlcke @ 2007-10-24 17:09 UTC (permalink / raw)
  To: linux-kernel, akpm; +Cc: Matthias Kaehlcke

[-- Attachment #1: char-mbcs-algolock-to-mutex --]
[-- Type: text/plain, Size: 2066 bytes --]

MBCS: Convert the semaphore algolock to the mutex API

Signed-off-by: Matthias Kaehlcke <matthias.kaehlcke@gmail.com>

--- kernel.orig/linux-2.6/drivers/char/mbcs.c	2007-10-23 17:37:56.000000000 +0200
+++ kernel/linux-2.6/drivers/char/mbcs.c	2007-10-23 17:40:16.000000000 +0200
@@ -24,6 +24,7 @@
 #include <linux/mm.h>
 #include <linux/fs.h>
 #include <linux/uio.h>
+#include <linux/mutex.h>
 #include <asm/io.h>
 #include <asm/uaccess.h>
 #include <asm/system.h>
@@ -282,7 +283,7 @@
 	void *mmr_base = soft->mmr_base;
 	union cm_control cm_control;
 
-	if (down_interruptible(&soft->algolock))
+	if (mutex_lock_interruptible(&soft->algolock))
 		return -ERESTARTSYS;
 
 	atomic_set(&soft->algo_done, 0);
@@ -299,7 +300,7 @@
 	cm_control.alg_go = 1;
 	MBCS_MMR_SET(mmr_base, MBCS_CM_CONTROL, cm_control.cm_control_reg);
 
-	up(&soft->algolock);
+	mutex_unlock(&soft->algolock);
 
 	return 0;
 }
@@ -765,7 +766,7 @@
 
 	init_MUTEX(&soft->dmawritelock);
 	init_MUTEX(&soft->dmareadlock);
-	init_MUTEX(&soft->algolock);
+	mutex_init(&soft->algolock);
 
 	mbcs_getdma_init(&soft->getdma);
 	mbcs_putdma_init(&soft->putdma);
Index: kernel/linux-2.6/drivers/char/mbcs.h
===================================================================
--- kernel.orig/linux-2.6/drivers/char/mbcs.h	2007-10-23 17:38:55.000000000 +0200
+++ kernel/linux-2.6/drivers/char/mbcs.h	2007-10-23 17:39:51.000000000 +0200
@@ -539,7 +539,7 @@
 	atomic_t algo_done;
 	struct semaphore dmawritelock;
 	struct semaphore dmareadlock;
-	struct semaphore algolock;
+	struct mutex algolock;
 };
 
 static int mbcs_open(struct inode *ip, struct file *fp);

-- 
Matthias Kaehlcke
Linux Application Developer
Barcelona

              We build too many walls and not enough bridges
                             (Isaac Newton)
                                                                 .''`.
    using free software / Debian GNU/Linux | http://debian.org  : :'  :
                                                                `. `'`
gpg --keyserver pgp.mit.edu --recv-keys 47D8E5D4                  `-

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [patch 2/3] MBCS: Convert dmawritelock to mutex
       [not found] <20071024170049.949862374@gmail.com>
  2007-10-24 17:09 ` [patch 1/3] MBCS: Convert algolock to mutex matthias.kaehlcke
@ 2007-10-24 17:09 ` matthias.kaehlcke
  2007-10-24 17:09 ` [patch 3/3] MBCS: Convert dmareadlock " matthias.kaehlcke
  2 siblings, 0 replies; 3+ messages in thread
From: matthias.kaehlcke @ 2007-10-24 17:09 UTC (permalink / raw)
  To: linux-kernel, akpm; +Cc: Matthias Kaehlcke

[-- Attachment #1: char-mbcs-dmawritelock-to-mutex --]
[-- Type: text/plain, Size: 1916 bytes --]

MBCS: Convert the semaphore dmawritelock to the mutex API

Signed-off-by: Matthias Kaehlcke <matthias.kaehlcke@gmail.com>

Index: kernel/linux-2.6/drivers/char/mbcs.h
===================================================================
--- kernel.orig/linux-2.6/drivers/char/mbcs.h	2007-10-23 17:50:50.000000000 +0200
+++ kernel/linux-2.6/drivers/char/mbcs.h	2007-10-24 17:02:12.000000000 +0200
@@ -537,7 +537,7 @@
 	atomic_t dmawrite_done;
 	atomic_t dmaread_done;
 	atomic_t algo_done;
-	struct semaphore dmawritelock;
+	struct mutex dmawritelock;
 	struct semaphore dmareadlock;
 	struct mutex algolock;
 };
Index: kernel/linux-2.6/drivers/char/mbcs.c
===================================================================
--- kernel.orig/linux-2.6/drivers/char/mbcs.c	2007-10-23 17:50:50.000000000 +0200
+++ kernel/linux-2.6/drivers/char/mbcs.c	2007-10-24 17:02:12.000000000 +0200
@@ -311,7 +311,7 @@
 {
 	int rv = 0;
 
-	if (down_interruptible(&soft->dmawritelock))
+	if (mutex_lock_interruptible(&soft->dmawritelock))
 		return -ERESTARTSYS;
 
 	atomic_set(&soft->dmawrite_done, 0);
@@ -337,7 +337,7 @@
 	*off += len;
 
 dmawrite_exit:
-	up(&soft->dmawritelock);
+	mutex_unlock(&soft->dmawritelock);
 
 	return rv;
 }
@@ -764,7 +764,7 @@
 	init_waitqueue_head(&soft->dmaread_queue);
 	init_waitqueue_head(&soft->algo_queue);
 
-	init_MUTEX(&soft->dmawritelock);
+	mutex_init(&soft->dmawritelock);
 	init_MUTEX(&soft->dmareadlock);
 	mutex_init(&soft->algolock);
 

-- 
Matthias Kaehlcke
Linux Application Developer
Barcelona

              We build too many walls and not enough bridges
                             (Isaac Newton)
                                                                 .''`.
    using free software / Debian GNU/Linux | http://debian.org  : :'  :
                                                                `. `'`
gpg --keyserver pgp.mit.edu --recv-keys 47D8E5D4                  `-

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [patch 3/3] MBCS: Convert dmareadlock to mutex
       [not found] <20071024170049.949862374@gmail.com>
  2007-10-24 17:09 ` [patch 1/3] MBCS: Convert algolock to mutex matthias.kaehlcke
  2007-10-24 17:09 ` [patch 2/3] MBCS: Convert dmawritelock " matthias.kaehlcke
@ 2007-10-24 17:09 ` matthias.kaehlcke
  2 siblings, 0 replies; 3+ messages in thread
From: matthias.kaehlcke @ 2007-10-24 17:09 UTC (permalink / raw)
  To: linux-kernel, akpm; +Cc: Matthias Kaehlcke

[-- Attachment #1: char-mbcs-dmareadlock-to-mutex --]
[-- Type: text/plain, Size: 1758 bytes --]

MBCS: Convert the semaphore dmareadlock to the mutex API

Signed-off-by: Matthias Kaehlcke <matthias.kaehlcke@gmail.com>

--- kernel.orig/linux-2.6/drivers/char/mbcs.c	2007-10-23 17:43:36.000000000 +0200
+++ kernel/linux-2.6/drivers/char/mbcs.c	2007-10-23 17:44:11.000000000 +0200
@@ -348,7 +348,7 @@
 {
 	int rv = 0;
 
-	if (down_interruptible(&soft->dmareadlock))
+	if (mutex_lock_interruptible(&soft->dmareadlock))
 		return -ERESTARTSYS;
 
 	atomic_set(&soft->dmawrite_done, 0);
@@ -373,7 +373,7 @@
 	*off += len;
 
 dmaread_exit:
-	up(&soft->dmareadlock);
+	mutex_unlock(&soft->dmareadlock);
 
 	return rv;
 }
@@ -765,7 +765,7 @@
 	init_waitqueue_head(&soft->algo_queue);
 
 	mutex_init(&soft->dmawritelock);
-	init_MUTEX(&soft->dmareadlock);
+	mutex_init(&soft->dmareadlock);
 	mutex_init(&soft->algolock);
 
 	mbcs_getdma_init(&soft->getdma);
Index: kernel/linux-2.6/drivers/char/mbcs.h
===================================================================
--- kernel.orig/linux-2.6/drivers/char/mbcs.h	2007-10-23 17:43:38.000000000 +0200
+++ kernel/linux-2.6/drivers/char/mbcs.h	2007-10-23 17:44:33.000000000 +0200
@@ -538,7 +538,7 @@
 	atomic_t dmaread_done;
 	atomic_t algo_done;
 	struct mutex dmawritelock;
-	struct semaphore dmareadlock;
+	struct mutex dmareadlock;
 	struct mutex algolock;
 };
 

-- 
Matthias Kaehlcke
Linux Application Developer
Barcelona

              We build too many walls and not enough bridges
                             (Isaac Newton)
                                                                 .''`.
    using free software / Debian GNU/Linux | http://debian.org  : :'  :
                                                                `. `'`
gpg --keyserver pgp.mit.edu --recv-keys 47D8E5D4                  `-

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2007-10-24 17:10 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20071024170049.949862374@gmail.com>
2007-10-24 17:09 ` [patch 1/3] MBCS: Convert algolock to mutex matthias.kaehlcke
2007-10-24 17:09 ` [patch 2/3] MBCS: Convert dmawritelock " matthias.kaehlcke
2007-10-24 17:09 ` [patch 3/3] MBCS: Convert dmareadlock " matthias.kaehlcke

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox