From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763398AbXJXRAb (ORCPT ); Wed, 24 Oct 2007 13:00:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1762933AbXJXQr0 (ORCPT ); Wed, 24 Oct 2007 12:47:26 -0400 Received: from ug-out-1314.google.com ([66.249.92.175]:54861 "EHLO ug-out-1314.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762899AbXJXQrZ (ORCPT ); Wed, 24 Oct 2007 12:47:25 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:from:to:subject:date:user-agent:cc:references:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:message-id; b=Y/3knJX43lAaUEgZS5SwCMPTMOWrk47KB/7KzDbTKUGHZm5MhX5f8N8RXhIBm505sTWJ/ThyKyAniSYOgcpEfHBJYXPDBguF3dSJgEl8wJ1SnDMJQ5e/9j5Y8FZ5Z7xVSui0O8clJDEchwY+QjcDGQLRLZHa6nems9XnhxXju3U= From: Maxim Levitsky To: Adrian Bunk Subject: Re: [2.6 patch] video/saa7134/: make 2 functions static Date: Wed, 24 Oct 2007 18:46:36 +0200 User-Agent: KMail/1.9.6 Cc: Mauro Carvalho Chehab , v4l-dvb-maintainer@linuxtv.org, linux-kernel@vger.kernel.org References: <20071024162314.GI30533@stusta.de> In-Reply-To: <20071024162314.GI30533@stusta.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200710241846.36695.maximlevitsky@gmail.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 24 October 2007 18:23:14 Adrian Bunk wrote: > saa7134_buffer_requeue() and set_tvnorm() can become static. > > Signed-off-by: Adrian Bunk > > --- > > drivers/media/video/saa7134/saa7134-core.c | 4 ++-- > drivers/media/video/saa7134/saa7134-video.c | 2 +- > drivers/media/video/saa7134/saa7134.h | 4 ---- > 3 files changed, 3 insertions(+), 7 deletions(-) > > 47fd0eba0eadebc28eac13b320e8f72879dc785a > diff --git a/drivers/media/video/saa7134/saa7134-core.c b/drivers/media/video/saa7134/saa7134-core.c > index 1a4a244..81ad03b 100644 > --- a/drivers/media/video/saa7134/saa7134-core.c > +++ b/drivers/media/video/saa7134/saa7134-core.c > @@ -395,8 +395,8 @@ void saa7134_buffer_timeout(unsigned long data) > > /* resends a current buffer in queue after resume */ > > -int saa7134_buffer_requeue(struct saa7134_dev *dev, > - struct saa7134_dmaqueue *q) > +static int saa7134_buffer_requeue(struct saa7134_dev *dev, > + struct saa7134_dmaqueue *q) > { > struct saa7134_buf *buf, *next; > > diff --git a/drivers/media/video/saa7134/saa7134-video.c b/drivers/media/video/saa7134/saa7134-video.c > index 471b927..bd3b303 100644 > --- a/drivers/media/video/saa7134/saa7134-video.c > +++ b/drivers/media/video/saa7134/saa7134-video.c > @@ -540,7 +540,7 @@ void res_free(struct saa7134_dev *dev, struct saa7134_fh *fh, unsigned int bits) > > /* ------------------------------------------------------------------ */ > > -void set_tvnorm(struct saa7134_dev *dev, struct saa7134_tvnorm *norm) > +static void set_tvnorm(struct saa7134_dev *dev, struct saa7134_tvnorm *norm) > { > > dprintk("set tv norm = %s\n",norm->name); > diff --git a/drivers/media/video/saa7134/saa7134.h b/drivers/media/video/saa7134/saa7134.h > index 28ec680..ac3ce77 100644 > --- a/drivers/media/video/saa7134/saa7134.h > +++ b/drivers/media/video/saa7134/saa7134.h > @@ -595,9 +595,6 @@ void saa7134_buffer_next(struct saa7134_dev *dev, struct saa7134_dmaqueue *q); > void saa7134_buffer_timeout(unsigned long data); > void saa7134_dma_free(struct videobuf_queue *q,struct saa7134_buf *buf); > > -int saa7134_buffer_requeue(struct saa7134_dev *dev, > - struct saa7134_dmaqueue *q); > - > int saa7134_set_dmabits(struct saa7134_dev *dev); > > extern int (*saa7134_dmasound_init)(struct saa7134_dev *dev); > @@ -630,7 +627,6 @@ void saa7134_i2c_call_clients(struct saa7134_dev *dev, > extern struct video_device saa7134_video_template; > extern struct video_device saa7134_radio_template; > > -void set_tvnorm(struct saa7134_dev *dev, struct saa7134_tvnorm *norm); > int saa7134_videoport_init(struct saa7134_dev *dev); > void saa7134_set_decoder(struct saa7134_dev *dev); > > > Agreed, I was using set_tvnorm, but now I don't use it, so its ok, thanks. sorry about, saa7134_buffer_requeue it should be static all the time. Best regards, Maxim Levitsky