* [PATCH 1/2] ssb: Add "ssb_pci_set_power_state" function
@ 2007-10-24 19:31 Miguel Botón
2007-10-24 20:55 ` Michael Buesch
2007-11-07 2:32 ` John W. Linville
0 siblings, 2 replies; 3+ messages in thread
From: Miguel Botón @ 2007-10-24 19:31 UTC (permalink / raw)
To: linux-kernel; +Cc: linux-wireless, linville, mb
Add "ssb_pci_set_power_state" function. This allows set the power state of a
PCI device (for example b44 ethernet device).
diff -ruN linux-2.6.23/include/linux/ssb/ssb.h
linux-2.6.23.orig/include/linux/ssb/ssb.h
--- linux-2.6.23.orig/include/linux/ssb/ssb.h 2007-10-24 19:02:33.000000000
+0200
+++ linux-2.6.23/include/linux/ssb/ssb.h 2007-10-24 19:49:37.000000000 +0200
@@ -402,6 +402,14 @@
{
pci_unregister_driver(driver);
}
+
+/* Set PCI device power state */
+static inline
+void ssb_pci_set_power_state(struct ssb_device *dev, pci_power_t state)
+{
+ if(dev->bus->bustype == SSB_BUSTYPE_PCI)
+ pci_set_power_state(dev->bus->host_pci, state);
+}
#endif /* CONFIG_SSB_PCIHOST */
--
Miguel Botón
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] ssb: Add "ssb_pci_set_power_state" function
2007-10-24 19:31 [PATCH 1/2] ssb: Add "ssb_pci_set_power_state" function Miguel Botón
@ 2007-10-24 20:55 ` Michael Buesch
2007-11-07 2:32 ` John W. Linville
1 sibling, 0 replies; 3+ messages in thread
From: Michael Buesch @ 2007-10-24 20:55 UTC (permalink / raw)
To: Miguel Botón; +Cc: linux-kernel, linux-wireless, linville
On Wednesday 24 October 2007 21:31:21 Miguel Botón wrote:
> Add "ssb_pci_set_power_state" function. This allows set the power state of a
> PCI device (for example b44 ethernet device).
>
> diff -ruN linux-2.6.23/include/linux/ssb/ssb.h
> linux-2.6.23.orig/include/linux/ssb/ssb.h
> --- linux-2.6.23.orig/include/linux/ssb/ssb.h 2007-10-24 19:02:33.000000000
> +0200
> +++ linux-2.6.23/include/linux/ssb/ssb.h 2007-10-24 19:49:37.000000000 +0200
> @@ -402,6 +402,14 @@
> {
> pci_unregister_driver(driver);
> }
> +
> +/* Set PCI device power state */
> +static inline
> +void ssb_pci_set_power_state(struct ssb_device *dev, pci_power_t state)
> +{
> + if(dev->bus->bustype == SSB_BUSTYPE_PCI)
^
Coding style issue.
> + pci_set_power_state(dev->bus->host_pci, state);
> +}
> #endif /* CONFIG_SSB_PCIHOST */
>
The rest is acked.
--
Greetings Michael.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] ssb: Add "ssb_pci_set_power_state" function
2007-10-24 19:31 [PATCH 1/2] ssb: Add "ssb_pci_set_power_state" function Miguel Botón
2007-10-24 20:55 ` Michael Buesch
@ 2007-11-07 2:32 ` John W. Linville
1 sibling, 0 replies; 3+ messages in thread
From: John W. Linville @ 2007-11-07 2:32 UTC (permalink / raw)
To: Miguel Botón; +Cc: linux-kernel, linux-wireless, mb
Miguel,
Along with the style point Michael suggested, I'll need you to repost
both this one and the b44 patch with at least a Signed-off-by line.
http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt
Also, please include the patches as plain text using a mailer that
does not damage whitespace.
Thanks,
John
On Wed, Oct 24, 2007 at 09:31:21PM +0200, Miguel Botón wrote:
> Add "ssb_pci_set_power_state" function. This allows set the power state of a
> PCI device (for example b44 ethernet device).
>
> diff -ruN linux-2.6.23/include/linux/ssb/ssb.h
> linux-2.6.23.orig/include/linux/ssb/ssb.h
> --- linux-2.6.23.orig/include/linux/ssb/ssb.h 2007-10-24 19:02:33.000000000
> +0200
> +++ linux-2.6.23/include/linux/ssb/ssb.h 2007-10-24 19:49:37.000000000 +0200
> @@ -402,6 +402,14 @@
> {
> pci_unregister_driver(driver);
> }
> +
> +/* Set PCI device power state */
> +static inline
> +void ssb_pci_set_power_state(struct ssb_device *dev, pci_power_t state)
> +{
> + if(dev->bus->bustype == SSB_BUSTYPE_PCI)
> + pci_set_power_state(dev->bus->host_pci, state);
> +}
> #endif /* CONFIG_SSB_PCIHOST */
>
>
>
> --
> Miguel Botón
--
John W. Linville
linville@tuxdriver.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-11-07 2:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-24 19:31 [PATCH 1/2] ssb: Add "ssb_pci_set_power_state" function Miguel Botón
2007-10-24 20:55 ` Michael Buesch
2007-11-07 2:32 ` John W. Linville
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox