public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak@suse.de>
To: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: Is gcc thread-unsafe?
Date: Thu, 25 Oct 2007 09:15:50 +0200	[thread overview]
Message-ID: <200710250915.50675.ak@suse.de> (raw)
In-Reply-To: <200710251324.49888.nickpiggin@yahoo.com.au>

On Thursday 25 October 2007 05:24, Nick Piggin wrote:

> Basically, what the gcc developers are saying is that gcc is
> free to load and store to any memory location, so long as it
> behaves as if the instructions were executed in sequence.

This case is clearly a bug, a very likely code pessimization.
I guess it wasn't intentional, just an optimization that is useful
for local register values doing too much.

> I guess that dynamically allocated memory and computed pointers
> are more difficult for gcc to do anything unsafe with, because
> it is harder to tell if a given function has deallocated the
> memory. 

Often accesses happen without function calls inbetween.
Also I think newer gcc (not 3.x) can determine if a pointer
"escapes" or not so that might not protect against it.

> Any thoughts?

We don't have much choice: If such a case is found it has to be marked
volatile or that particular compiler version be unsupported.

It might be useful to come up with some kind of assembler pattern
matcher to check if any such code is generated for the kernel
and try it with different compiler versions.

-Andi

  parent reply	other threads:[~2007-10-25  7:19 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-25  3:24 Is gcc thread-unsafe? Nick Piggin
2007-10-25  3:46 ` Arjan van de Ven
2007-10-25  3:58   ` Nick Piggin
2007-10-25  4:29     ` David Schwartz
2007-10-25  4:35       ` Arjan van de Ven
2007-10-25 18:45         ` Måns Rullgård
2007-10-25  4:47       ` Nick Piggin
2007-10-25  9:40         ` Samuel Tardieu
2007-10-25  9:44         ` Samuel Tardieu
2007-10-25  9:54           ` Samuel Tardieu
2007-10-25  9:55           ` Andi Kleen
2007-10-25  7:15 ` Andi Kleen [this message]
2007-10-25 11:58   ` linux-os (Dick Johnson)
2007-10-25 12:16     ` Andi Kleen
2007-10-25 22:49   ` Nick Piggin
2007-10-25 23:09     ` Andi Kleen
2007-10-25 23:14       ` Linus Torvalds
2007-10-25 23:16         ` Andi Kleen
2007-10-25 23:32           ` Linus Torvalds
2007-10-25 23:42             ` Andi Kleen
2007-10-25 23:57               ` Linus Torvalds
2007-10-26  1:15                 ` Zachary Amsden
2007-10-26  4:57               ` Willy Tarreau
2007-10-25 23:43       ` Nick Piggin
2007-10-25 23:55         ` Andi Kleen
2007-10-25 23:57           ` Nick Piggin
2007-10-25 14:55 ` Linus Torvalds
2007-10-25 15:12   ` Pekka Enberg
2007-10-25 21:42   ` David Schwartz
2007-10-25 23:22     ` Nick Piggin
2007-10-26 11:59       ` Andrew Haley
2007-10-26 11:59       ` Andrew Haley
2007-10-26 17:39         ` Chris Friesen
2007-10-25 22:26   ` Ismail Dönmez
2007-10-25 22:56     ` Jeff Garzik
2007-10-25 23:04       ` Jeff Garzik
2007-10-31 22:10 ` Phillip Susi
     [not found] <fa.JbRGo0cQWncrcfKHmiNdvchsA50@ifi.uio.no>
     [not found] ` <fa.8qDECVaPIo7DWbjhQbyw6N5Infg@ifi.uio.no>
     [not found]   ` <fa.M4DOMggyrQmdTqekWSuw4xCxiTc@ifi.uio.no>
2007-10-25 23:27     ` Robert Hancock
     [not found] <e2e108260710260729x4603211cgb68d7434ce1e54e9@mail.gmail.com>
2007-10-26 14:40 ` Bart Van Assche
2007-10-26 15:09   ` Linus Torvalds
2007-10-26 15:34     ` Andrew Haley
2007-10-26 18:06       ` David Schwartz
2007-10-30 10:20         ` Andrew Haley
2007-11-02 15:29           ` Bart Van Assche
2007-11-02 15:38             ` Andrew Haley
2007-11-04 15:13               ` Bart Van Assche
2007-11-04 17:45                 ` Linus Torvalds
2007-11-04 17:58                   ` Andrew Haley
2007-11-04 18:06                   ` Bart Van Assche
2007-11-02 17:18             ` David Schwartz
2007-10-26 21:45     ` Giacomo Catenazzi
2007-10-26 22:24       ` Linus Torvalds
2007-10-26 15:27   ` Linus Torvalds
2007-10-26 16:28     ` Linus Torvalds
2007-10-26 17:07       ` Bart Van Assche
2007-10-26 17:12         ` Andrew Haley
2007-10-26 17:25           ` Linus Torvalds
2007-10-26 18:08         ` Alan Cox
2007-10-26 18:14           ` Linus Torvalds
2007-10-26 20:39           ` Andi Kleen
  -- strict thread matches above, loose matches on Subject: below --
2007-10-28 18:19 linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200710250915.50675.ak@suse.de \
    --to=ak@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nickpiggin@yahoo.com.au \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox