From: Rolf Eike Beer <eike-kernel@sf-tec.de>
To: Arjan van de Ven <arjan@infradead.org>
Cc: Hugh Dickins <hugh@veritas.com>,
Jens Axboe <jens.axboe@oracle.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.24-rc1] fix sg_phys to use dma_addr_t
Date: Thu, 25 Oct 2007 10:51:24 +0200 [thread overview]
Message-ID: <200710251051.30429.eike-kernel@sf-tec.de> (raw)
In-Reply-To: <20071024192949.346687ed@laptopd505.fenrus.org>
[-- Attachment #1: Type: text/plain, Size: 807 bytes --]
Am Donnerstag, 25. Oktober 2007 schrieb Arjan van de Ven:
> > Signed-off-by: Hugh Dickins <hugh@veritas.com>
> > ---
> > Whether this is a complete patch, suitable for all architectures,
> > I'm not sure: it builds, boots and runs correctly on the x86_32 box
> > in question, but you'll be a lot wiser than me about using dma_addr_t
> > for everyone. (Seems a bit of a shame to include <asm/types.h> here,
> > when I think all arches already get to include it one way or another,
> > typically via asm/scatterlist.h; but I guess it's safest to repeat
> > it.)
>
> there is a problem with this... sg_phys doesn't return an actual *dma*
> address.... at least not an address you can give to the device.
> Using dma_addr_t is thus a bit misleading.....
Ok, then: how do I actually get such an address?
Eike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 194 bytes --]
next prev parent reply other threads:[~2007-10-25 8:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-24 19:01 [PATCH 2.6.24-rc1] fix sg_phys to use dma_addr_t Hugh Dickins
2007-10-25 2:29 ` Arjan van de Ven
2007-10-25 6:40 ` Hugh Dickins
2007-10-25 7:54 ` Jens Axboe
2007-10-25 8:51 ` Rolf Eike Beer [this message]
2007-10-25 8:52 ` Jens Axboe
2007-10-25 9:00 ` Rolf Eike Beer
2007-10-25 9:06 ` Jens Axboe
2007-10-25 11:24 ` Rolf Eike Beer
2007-10-25 11:30 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200710251051.30429.eike-kernel@sf-tec.de \
--to=eike-kernel@sf-tec.de \
--cc=arjan@infradead.org \
--cc=hugh@veritas.com \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox