From: Andrew Morton <akpm@linux-foundation.org>
To: Randy Dunlap <rdunlap@xenotime.net>
Cc: tglx@linutronix.de, nickpiggin@yahoo.com.au, mingo@redhat.com,
hpa@zytor.com, linux-kernel@vger.kernel.org,
torvalds@linux-foundation.org, Andy Whitcroft <apw@shadowen.org>
Subject: Re: [PATCH v2] bitops kernel-doc: inline instead of macro
Date: Thu, 25 Oct 2007 13:48:14 -0700 [thread overview]
Message-ID: <20071025134814.caced2e3.akpm@linux-foundation.org> (raw)
In-Reply-To: <20071025095540.827d4333.rdunlap@xenotime.net>
On Thu, 25 Oct 2007 09:55:40 -0700
Randy Dunlap <rdunlap@xenotime.net> wrote:
> -#define test_and_set_bit_lock test_and_set_bit
> +static __inline__ int test_and_set_bit_lock(int nr, volatile void * addr)
mutter.
ERROR: "foo * bar" should be "foo *bar"
#80: FILE: include/asm-x86/bitops_32.h:188:
+static inline int test_and_set_bit_lock(int nr, volatile unsigned long * addr)
WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt
#80: FILE: include/asm-x86/bitops_32.h:188:
+static inline int test_and_set_bit_lock(int nr, volatile unsigned long * addr)
ERROR: "foo * bar" should be "foo *bar"
#97: FILE: include/asm-x86/bitops_64.h:178:
+static __inline__ int test_and_set_bit_lock(int nr, volatile void * addr)
WARNING: Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt
#97: FILE: include/asm-x86/bitops_64.h:178:
+static __inline__ int test_and_set_bit_lock(int nr, volatile void * addr)
total: 2 errors, 2 warnings, 28 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
We might as well clean stuff up as we're churning the code.
Andy, I thought we were going to whine about __inline__ and __inline, too?
next prev parent reply other threads:[~2007-10-25 20:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-24 5:09 [PATCH] bitops kernel-doc: expand macro Randy Dunlap
2007-10-24 8:00 ` Nick Piggin
2007-10-24 15:38 ` Randy Dunlap
2007-10-25 16:31 ` [PATCH v2] bitops kernel-doc: inline instead of macro Randy Dunlap
2007-10-25 16:42 ` Thomas Gleixner
2007-10-25 16:55 ` Randy Dunlap
2007-10-25 17:05 ` Thomas Gleixner
2007-10-25 20:48 ` Andrew Morton [this message]
2007-10-25 21:21 ` [PATCH v3] " Randy Dunlap
2007-10-25 21:27 ` Thomas Gleixner
2007-10-25 21:27 ` [PATCH] x86 bitops: fix code style issues Randy Dunlap
2007-10-27 10:43 ` [PATCH v2] bitops kernel-doc: inline instead of macro Andy Whitcroft
2007-10-27 14:30 ` Andy Whitcroft
2007-10-27 18:48 ` H. Peter Anvin
2007-10-25 21:54 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071025134814.caced2e3.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=apw@shadowen.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=nickpiggin@yahoo.com.au \
--cc=rdunlap@xenotime.net \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox