Re: [PATCH] Fix /proc/acpi/alarm BCD alarm encodings

[Andrew Morton <akpm@linux-foundation.org>]

On Thu, 25 Oct 2007 15:04:18 -0700 (PDT)
Linus Torvalds <torvalds@linux-foundation.org> wrote:

> 
> 
> On Thu, 18 Oct 2007, Andrew Morton wrote:
> 
> > On Wed, 17 Oct 2007 23:18:32 -0400
> > Mark Lord <lkml@rtr.ca> wrote:
> > 
> > > >and note the "& 0x3f" which is done in BCD mode. Strange. But we always 
> > > >write zero (which may or may not be correct). So I'd have to add a mask to 
> > > >the interface, and I decided it wasn't worth it until somebody talks about 
> > > >how that thing actually works..
> > > 
> > > Linus, this is your patch from a few weeks ago.
> > > It (still) solves problems for me here.
> > > This should go into 2.6.24.
> > > 
> > > Fix BIN_TO_BCD()/BCD_TO_BIN() handling when setting the real-time alarm clock.
> > 
> > This patch is presently (stuck) in -mm.  I'll move it to my
> > must-be-in-2.6.24-even-if-the-maintainer-fluffs-it queue.
> 
> I noticed that apparently this never happened, and it didn't go into -rc1.
> 
> I'll put it there myself, since I'm the author and Mark tested it, and the 
> old code was definitely totally buggy. The earlier it gets in, the better, 
> in case there are cleanups and/or other issues.
> 

I'll send over my copy.  I don't think it changed.