From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1756111AbXJYWN6@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756111AbXJYWN6 (ORCPT <rfc822;w@1wt.eu>);
	Thu, 25 Oct 2007 18:13:58 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752813AbXJYWNv
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Thu, 25 Oct 2007 18:13:51 -0400
Received: from smtp2.linux-foundation.org ([207.189.120.14]:50600 "EHLO
	smtp2.linux-foundation.org" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1750732AbXJYWNu (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 25 Oct 2007 18:13:50 -0400
Date: Thu, 25 Oct 2007 15:13:34 -0700
From: Andrew Morton <akpm@linux-foundation.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: lkml@rtr.ca, linux-kernel@vger.kernel.org, Len Brown <lenb@kernel.org>
Subject: Re: [PATCH] Fix /proc/acpi/alarm BCD alarm encodings
Message-Id: <20071025151334.f8879fe5.akpm@linux-foundation.org>
In-Reply-To: <alpine.LFD.0.999.0710251502430.30120@woody.linux-foundation.org>
References: <4716D088.3040608@rtr.ca>
	<20071018151114.b1a0431e.akpm@linux-foundation.org>
	<alpine.LFD.0.999.0710251502430.30120@woody.linux-foundation.org>
X-Mailer: Sylpheed version 2.2.4 (GTK+ 2.8.20; i486-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 25 Oct 2007 15:04:18 -0700 (PDT)
Linus Torvalds <torvalds@linux-foundation.org> wrote:

> 
> 
> On Thu, 18 Oct 2007, Andrew Morton wrote:
> 
> > On Wed, 17 Oct 2007 23:18:32 -0400
> > Mark Lord <lkml@rtr.ca> wrote:
> > 
> > > >and note the "& 0x3f" which is done in BCD mode. Strange. But we always 
> > > >write zero (which may or may not be correct). So I'd have to add a mask to 
> > > >the interface, and I decided it wasn't worth it until somebody talks about 
> > > >how that thing actually works..
> > > 
> > > Linus, this is your patch from a few weeks ago.
> > > It (still) solves problems for me here.
> > > This should go into 2.6.24.
> > > 
> > > Fix BIN_TO_BCD()/BCD_TO_BIN() handling when setting the real-time alarm clock.
> > 
> > This patch is presently (stuck) in -mm.  I'll move it to my
> > must-be-in-2.6.24-even-if-the-maintainer-fluffs-it queue.
> 
> I noticed that apparently this never happened, and it didn't go into -rc1.
> 
> I'll put it there myself, since I'm the author and Mark tested it, and the 
> old code was definitely totally buggy. The earlier it gets in, the better, 
> in case there are cleanups and/or other issues.
> 

I'll send over my copy.  I don't think it changed.