* [2.6 patch] unexport tick_nohz_get_sleep_length @ 2007-10-24 16:24 Adrian Bunk 2007-10-25 9:28 ` Thomas Gleixner 0 siblings, 1 reply; 5+ messages in thread From: Adrian Bunk @ 2007-10-24 16:24 UTC (permalink / raw) To: Len Brown, Thomas Gleixner; +Cc: linux-kernel This patch removes the unused EXPORT_SYMBOL_GPL(tick_nohz_get_sleep_length). Signed-off-by: Adrian Bunk <bunk@kernel.org> --- f7c83dfe117f4fd072b2506ae090e4145abda362 diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c index 10a1347..5997456 100644 --- a/kernel/time/tick-sched.c +++ b/kernel/time/tick-sched.c @@ -320,8 +320,6 @@ ktime_t tick_nohz_get_sleep_length(void) return ts->sleep_length; } -EXPORT_SYMBOL_GPL(tick_nohz_get_sleep_length); - /** * nohz_restart_sched_tick - restart the idle tick from the idle task * ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [2.6 patch] unexport tick_nohz_get_sleep_length 2007-10-24 16:24 [2.6 patch] unexport tick_nohz_get_sleep_length Adrian Bunk @ 2007-10-25 9:28 ` Thomas Gleixner 2007-10-25 16:51 ` Pallipadi, Venkatesh 0 siblings, 1 reply; 5+ messages in thread From: Thomas Gleixner @ 2007-10-25 9:28 UTC (permalink / raw) To: Adrian Bunk; +Cc: Len Brown, LKML, Venkatesch Pallipadi On Wed, 24 Oct 2007, Adrian Bunk wrote: > This patch removes the unused > EXPORT_SYMBOL_GPL(tick_nohz_get_sleep_length). > > Signed-off-by: Adrian Bunk <bunk@kernel.org> > > --- > f7c83dfe117f4fd072b2506ae090e4145abda362 > diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c > index 10a1347..5997456 100644 > --- a/kernel/time/tick-sched.c > +++ b/kernel/time/tick-sched.c > @@ -320,8 +320,6 @@ ktime_t tick_nohz_get_sleep_length(void) > return ts->sleep_length; > } > > -EXPORT_SYMBOL_GPL(tick_nohz_get_sleep_length); > - Hmm, this was added to allow the cpuidle governers modular build. Seems this was changed to compiled in only. Len, Venki, is this the final decision ? tglx ^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [2.6 patch] unexport tick_nohz_get_sleep_length 2007-10-25 9:28 ` Thomas Gleixner @ 2007-10-25 16:51 ` Pallipadi, Venkatesh 2007-10-25 16:56 ` Thomas Gleixner 0 siblings, 1 reply; 5+ messages in thread From: Pallipadi, Venkatesh @ 2007-10-25 16:51 UTC (permalink / raw) To: Thomas Gleixner, Adrian Bunk; +Cc: Brown, Len, LKML >-----Original Message----- >From: Thomas Gleixner [mailto:tglx@linutronix.de] >Sent: Thursday, October 25, 2007 2:28 AM >To: Adrian Bunk >Cc: Brown, Len; LKML; Pallipadi, Venkatesh >Subject: Re: [2.6 patch] unexport tick_nohz_get_sleep_length > >On Wed, 24 Oct 2007, Adrian Bunk wrote: > >> This patch removes the unused >> EXPORT_SYMBOL_GPL(tick_nohz_get_sleep_length). >> >> Signed-off-by: Adrian Bunk <bunk@kernel.org> >> >> --- >> f7c83dfe117f4fd072b2506ae090e4145abda362 >> diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c >> index 10a1347..5997456 100644 >> --- a/kernel/time/tick-sched.c >> +++ b/kernel/time/tick-sched.c >> @@ -320,8 +320,6 @@ ktime_t tick_nohz_get_sleep_length(void) >> return ts->sleep_length; >> } >> >> -EXPORT_SYMBOL_GPL(tick_nohz_get_sleep_length); >> - > >Hmm, this was added to allow the cpuidle governers modular >build. Seems this was changed to compiled in only. > >Len, Venki, is this the final decision ? > Yes. This was done recently for proper fallback to old ACPI policy in case CPUIDLE is not selected. With that being module, falling back to ACPI policy at run time makes things ugly. Thanks, Venki ^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [2.6 patch] unexport tick_nohz_get_sleep_length 2007-10-25 16:51 ` Pallipadi, Venkatesh @ 2007-10-25 16:56 ` Thomas Gleixner 2007-10-25 21:40 ` Len Brown 0 siblings, 1 reply; 5+ messages in thread From: Thomas Gleixner @ 2007-10-25 16:56 UTC (permalink / raw) To: Pallipadi, Venkatesh; +Cc: Adrian Bunk, Brown, Len, LKML On Thu, 25 Oct 2007, Pallipadi, Venkatesh wrote: > >On Wed, 24 Oct 2007, Adrian Bunk wrote: > > > >> This patch removes the unused > >> EXPORT_SYMBOL_GPL(tick_nohz_get_sleep_length). > >> > >> Signed-off-by: Adrian Bunk <bunk@kernel.org> > >> > >> --- > >> f7c83dfe117f4fd072b2506ae090e4145abda362 > >> diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c > >> index 10a1347..5997456 100644 > >> --- a/kernel/time/tick-sched.c > >> +++ b/kernel/time/tick-sched.c > >> @@ -320,8 +320,6 @@ ktime_t tick_nohz_get_sleep_length(void) > >> return ts->sleep_length; > >> } > >> > >> -EXPORT_SYMBOL_GPL(tick_nohz_get_sleep_length); > >> - > > > >Hmm, this was added to allow the cpuidle governers modular > >build. Seems this was changed to compiled in only. > > > >Len, Venki, is this the final decision ? > > > > Yes. This was done recently for proper fallback to old ACPI policy in > case CPUIDLE is not selected. With that being module, falling back to > ACPI policy at run time makes things ugly. Makes sense. I go ahead and nuke the export. Thanks, tglx ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [2.6 patch] unexport tick_nohz_get_sleep_length 2007-10-25 16:56 ` Thomas Gleixner @ 2007-10-25 21:40 ` Len Brown 0 siblings, 0 replies; 5+ messages in thread From: Len Brown @ 2007-10-25 21:40 UTC (permalink / raw) To: Thomas Gleixner; +Cc: Pallipadi, Venkatesh, Adrian Bunk, LKML Applied. thanks, -Len On Thursday 25 October 2007 12:56, Thomas Gleixner wrote: > On Thu, 25 Oct 2007, Pallipadi, Venkatesh wrote: > > >On Wed, 24 Oct 2007, Adrian Bunk wrote: > > > > > >> This patch removes the unused > > >> EXPORT_SYMBOL_GPL(tick_nohz_get_sleep_length). > > >> > > >> Signed-off-by: Adrian Bunk <bunk@kernel.org> > > >> > > >> --- > > >> f7c83dfe117f4fd072b2506ae090e4145abda362 > > >> diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c > > >> index 10a1347..5997456 100644 > > >> --- a/kernel/time/tick-sched.c > > >> +++ b/kernel/time/tick-sched.c > > >> @@ -320,8 +320,6 @@ ktime_t tick_nohz_get_sleep_length(void) > > >> return ts->sleep_length; > > >> } > > >> > > >> -EXPORT_SYMBOL_GPL(tick_nohz_get_sleep_length); > > >> - > > > > > >Hmm, this was added to allow the cpuidle governers modular > > >build. Seems this was changed to compiled in only. > > > > > >Len, Venki, is this the final decision ? > > > > > > > Yes. This was done recently for proper fallback to old ACPI policy in > > case CPUIDLE is not selected. With that being module, falling back to > > ACPI policy at run time makes things ugly. > > Makes sense. I go ahead and nuke the export. > > Thanks, > > tglx > - > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2007-10-25 21:40 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2007-10-24 16:24 [2.6 patch] unexport tick_nohz_get_sleep_length Adrian Bunk 2007-10-25 9:28 ` Thomas Gleixner 2007-10-25 16:51 ` Pallipadi, Venkatesh 2007-10-25 16:56 ` Thomas Gleixner 2007-10-25 21:40 ` Len Brown
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox