public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Len Brown <lenb@kernel.org>
To: Jonathan Woithe <jwoithe@physics.adelaide.edu.au>
Cc: Adrian Bunk <bunk@kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] fujitsu-laptop.c: remove dead code
Date: Thu, 25 Oct 2007 17:44:09 -0400	[thread overview]
Message-ID: <200710251744.10035.lenb@kernel.org> (raw)
In-Reply-To: <200710250508.l9P58exp003251@turbo.physics.adelaide.edu.au>

Applied.

thanks,
-len

On Thursday 25 October 2007 01:08, Jonathan Woithe wrote:
> > This patch removes dead code spotted by the Coverity checker.
> > 
> > Signed-off-by: Adrian Bunk <bunk@kernel.org>
> 
> Ack.
> 
> Signed-off-by: Jonathan Woithe <jwoithe@physics.adelaide.edu.au>
> 
> jonathan
> 
> ---
> --- linux-2.6/drivers/misc/fujitsu-laptop.c.old	2007-10-23 18:51:10.000000000 +0200
> +++ linux-2.6/drivers/misc/fujitsu-laptop.c	2007-10-23 18:51:50.000000000 +0200
> @@ -110,33 +110,30 @@ static int get_lcd_level(void)
>  
>  	// Get the Brightness
>  	status =
>  	    acpi_evaluate_integer(fujitsu->acpi_handle, "GBLL", NULL, &state);
>  	if (status < 0)
>  		return status;
>  
>  	fujitsu->fuj02b1_state = state;
>  	fujitsu->brightness_level = state & 0x0fffffff;
>  
>  	if (state & 0x80000000)
>  		fujitsu->brightness_changed = 1;
>  	else
>  		fujitsu->brightness_changed = 0;
>  
> -	if (status < 0)
> -		return status;
> -
>  	return fujitsu->brightness_level;
>  }
>  
>  /* Backlight device stuff */
>  
>  static int bl_get_brightness(struct backlight_device *b)
>  {
>  	return get_lcd_level();
>  }
>  
>  static int bl_update_status(struct backlight_device *b)
>  {
>  	return set_lcd_level(b->props.brightness);
>  }
>  
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 

      reply	other threads:[~2007-10-25 21:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-24 16:25 [2.6 patch] fujitsu-laptop.c: remove dead code Adrian Bunk
2007-10-25  5:08 ` Jonathan Woithe
2007-10-25 21:44   ` Len Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200710251744.10035.lenb@kernel.org \
    --to=lenb@kernel.org \
    --cc=bunk@kernel.org \
    --cc=jwoithe@physics.adelaide.edu.au \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox