public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/4]: Resolve MSI vs. INTX_DISABLE quirks, V2.
@ 2007-10-25  8:14 David Miller
  2007-10-25  8:24 ` [PATCH 0/5]: " Jeff Garzik
  2007-10-25 18:32 ` [PATCH 0/4]: " Greg KH
  0 siblings, 2 replies; 4+ messages in thread
From: David Miller @ 2007-10-25  8:14 UTC (permalink / raw)
  To: linux-kernel
  Cc: jeff, barkalow, linas, chunhao.huang, gregkh, htejun,
	brice.goglin, david.gaarenstroom, linux-pci, shane.huang,
	linux-ide, brice, mchan


Ok, I've respun the patches including all of the feedback I've
obtained.  Again, it's at:

	kernel.org:/pub/scm/linux/kernel/git/davem/msiquirk-2.6.git

Greg, I think this stuff is ready to go so if you would pull
them in I would really appreciate it.

These changes clean up the handling of the common quirk wherein
setting INTX_DISABLE will mistakedly disable MSI generation for some
devices.

For devices without that problem, we want to keep the pci_intx() calls
in drivers/pci/msi.c because those help protect against devices with
the opposite problem.  Such devices always generate INTX interrupts
even when MSI is enabled, unless INTX_DISABLE is set.

In addition to the Tigon3 cases, I added quirk entries for the
SB700/800 SATA chips and the IXP SB400 USB controllers.  And as
a result of the latter we can remove several AMD full-chipset
MSI disable quirks which are no longer necessary.

Signed-off-by: David S. Miller <davem@davemloft.net>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 0/5]: Resolve MSI vs. INTX_DISABLE quirks, V2.
  2007-10-25  8:14 [PATCH 0/4]: Resolve MSI vs. INTX_DISABLE quirks, V2 David Miller
@ 2007-10-25  8:24 ` Jeff Garzik
  2007-10-25 18:32 ` [PATCH 0/4]: " Greg KH
  1 sibling, 0 replies; 4+ messages in thread
From: Jeff Garzik @ 2007-10-25  8:24 UTC (permalink / raw)
  To: David Miller
  Cc: linux-kernel, barkalow, linas, chunhao.huang, gregkh, htejun,
	brice.goglin, david.gaarenstroom, linux-pci, shane.huang,
	linux-ide, brice, mchan

David Miller wrote:
> Ok, I've respun the patches including all of the feedback I've
> obtained.  Again, it's at:
> 
> 	kernel.org:/pub/scm/linux/kernel/git/davem/msiquirk-2.6.git
> 
> Greg, I think this stuff is ready to go so if you would pull
> them in I would really appreciate it.
> 
> These changes clean up the handling of the common quirk wherein
> setting INTX_DISABLE will mistakedly disable MSI generation for some
> devices.
> 
> For devices without that problem, we want to keep the pci_intx() calls
> in drivers/pci/msi.c because those help protect against devices with
> the opposite problem.  Such devices always generate INTX interrupts
> even when MSI is enabled, unless INTX_DISABLE is set.
> 
> In addition to the Tigon3 cases, I added quirk entries for the
> SB700/800 SATA chips and the IXP SB400 USB controllers.  And as
> a result of the latter we can remove several AMD full-chipset
> MSI disable quirks which are no longer necessary.
> 
> Signed-off-by: David S. Miller <davem@davemloft.net>

[corrected subject line s/4/5/.  the actual patches are OK]

Acked-by: Jeff Garzik <jgarzik@redhat.com>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 0/4]: Resolve MSI vs. INTX_DISABLE quirks, V2.
  2007-10-25  8:14 [PATCH 0/4]: Resolve MSI vs. INTX_DISABLE quirks, V2 David Miller
  2007-10-25  8:24 ` [PATCH 0/5]: " Jeff Garzik
@ 2007-10-25 18:32 ` Greg KH
  2007-10-25 22:27   ` David Miller
  1 sibling, 1 reply; 4+ messages in thread
From: Greg KH @ 2007-10-25 18:32 UTC (permalink / raw)
  To: David Miller
  Cc: linux-kernel, jeff, barkalow, linas, chunhao.huang, gregkh,
	htejun, brice.goglin, david.gaarenstroom, linux-pci, shane.huang,
	linux-ide, brice, mchan

On Thu, Oct 25, 2007 at 01:14:45AM -0700, David Miller wrote:
> 
> Ok, I've respun the patches including all of the feedback I've
> obtained.  Again, it's at:
> 
> 	kernel.org:/pub/scm/linux/kernel/git/davem/msiquirk-2.6.git
> 
> Greg, I think this stuff is ready to go so if you would pull
> them in I would really appreciate it.

These all look great to me, and I've pulled them into my trees.

Thanks a lot for doing this work.

I think they should go to Linus before 2.6.24 is out, any objection from
anyone else with this?

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH 0/4]: Resolve MSI vs. INTX_DISABLE quirks, V2.
  2007-10-25 18:32 ` [PATCH 0/4]: " Greg KH
@ 2007-10-25 22:27   ` David Miller
  0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2007-10-25 22:27 UTC (permalink / raw)
  To: greg
  Cc: linux-kernel, jeff, barkalow, linas, chunhao.huang, gregkh,
	htejun, brice.goglin, david.gaarenstroom, linux-pci, shane.huang,
	linux-ide, brice, mchan

From: Greg KH <greg@kroah.com>
Date: Thu, 25 Oct 2007 11:32:48 -0700

> These all look great to me, and I've pulled them into my trees.
> 
> Thanks a lot for doing this work.

Thanks for integrating.

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2007-10-25 22:28 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-25  8:14 [PATCH 0/4]: Resolve MSI vs. INTX_DISABLE quirks, V2 David Miller
2007-10-25  8:24 ` [PATCH 0/5]: " Jeff Garzik
2007-10-25 18:32 ` [PATCH 0/4]: " Greg KH
2007-10-25 22:27   ` David Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox