public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: "Russ Dill" <russ.dill@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Better document profile=
Date: Thu, 25 Oct 2007 22:21:55 -0700	[thread overview]
Message-ID: <20071025222155.9534a6d7.akpm@linux-foundation.org> (raw)
In-Reply-To: <f9d2a5e10710252203n7ff40690j8d4822310826f9e8@mail.gmail.com>

On Thu, 25 Oct 2007 22:03:21 -0700 "Russ Dill" <russ.dill@gmail.com> wrote:

> > >                       Format: [schedule,]<number>
> > >                       Param: "schedule" - profile schedule points.
> > >                       Param: <number> - step/bucket size as a power of 2 for
> > > -                             statistical time based profiling.
> > > +                             statistical time based profiling. A value of
> > > +                             2 will provide a granularity of 4 bytes, a
> > > +                             value of 3 will provide a granularity of 8
> > > +                             bytes and so on.
> > >                       Param: "sleep" - profile D-state sleeping (millisecs)
> >
> > Actually the prof_shift isn't in units of bytes: it is in units of
> > sizeof(unsigned long).
> 
> 
> I thought we just went through this?

Just.  I seem to recall discussing this with someone a number of weeks ago.
Sorry, but my memory gets flushed a lot more frequently than that.

> extern char _text[], _stext[], _etext[];
> [...]
> prof_len = (_etext - _stext) >> prof_shift;
> prof_buffer = alloc_bootmem(prof_len*sizeof(atomic_t));
> 

ok, you're right.

      reply	other threads:[~2007-10-26  5:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-17  5:16 [PATCH] Better document profile= Russ Dill
2007-10-25 23:37 ` Andrew Morton
2007-10-26  5:03   ` Russ Dill
2007-10-26  5:21     ` Andrew Morton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071025222155.9534a6d7.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=russ.dill@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox