From: David Miller <davem@davemloft.net>
To: rientjes@google.com
Cc: adobriyan@sw.ru, torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] De-constify sched.h
Date: Fri, 26 Oct 2007 02:50:29 -0700 (PDT) [thread overview]
Message-ID: <20071026.025029.00497274.davem@davemloft.net> (raw)
In-Reply-To: <alpine.DEB.0.9999.0710260235130.8261@chino.kir.corp.google.com>
From: David Rientjes <rientjes@google.com>
Date: Fri, 26 Oct 2007 02:42:30 -0700 (PDT)
> On Fri, 26 Oct 2007, Alexey Dobriyan wrote:
>
> > 2) There is no such thing as const task_struct. Anyone who think otherwise
> > deserves compiler warning.
> >
>
> A 'const struct task_struct *' can be used as an annotation to mean that
> no member of the struct is modified through that pointer, so it's
> perfectly acceptable to qualify formals in that manner.
But in one of the cases he un-const's the code does modify
the object through the pointer. At least that one should
be reverted since the annotation is wrong.
next prev parent reply other threads:[~2007-10-26 9:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-26 8:17 [PATCH] De-constify sched.h Alexey Dobriyan
2007-10-26 9:42 ` David Rientjes
2007-10-26 9:50 ` David Miller [this message]
2007-10-26 17:32 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071026.025029.00497274.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=adobriyan@sw.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=rientjes@google.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox