public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Randy Dunlap <randy.dunlap@oracle.com>
To: Keiichi KII <k-keiichi@bx.jp.nec.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	gregkh@suse.de, Andy Whitcroft <apw@shadowen.org>
Subject: Re: [PATCH 1/2] fix typo in SubmittingPatches
Date: Fri, 26 Oct 2007 20:50:09 -0700	[thread overview]
Message-ID: <20071026205009.24ec2d83.randy.dunlap@oracle.com> (raw)
In-Reply-To: <47218E80.50700@bx.jp.nec.com>

On Fri, 26 Oct 2007 15:51:44 +0900 Keiichi KII wrote:

> From: Keiichi Kii <k-keiichi@bx.jp.nec.com>
> 
> Fix typo.
> 
> Signed-off-by: Keiichi Kii <k-keiichi@bx.jp.nec.com>
> Cc: Andy Whitcroft <apw@shadowen.org>
> ---
> Index: trunk/Documentation/SubmittingPatches
> ===================================================================
> --- trunk.orig/Documentation/SubmittingPatches
> +++ trunk/Documentation/SubmittingPatches
> @@ -464,7 +464,7 @@ section Linus Computer Science 101.
>  Nuff said.  If your code deviates too much from this, it is likely
>  to be rejected without further review, and without comment.
>  
> -Once significant exception is when moving code from one file to
> +One significant exception is when moving code from one file to
>  another in this case you should not modify the moved code at all in
>  the same patch which moves it.  This clearly delineates the act of
>  moving the code and your changes.  This greatly aids review of the

That first sentence is still broken.  It should be more like this,
with either a ":" or ";" or " -- " between clauses:

One significant exception is when moving code from one file to
another -- in this case you should not modify the moved code at all in
the same patch which moves it.


---
~Randy

  reply	other threads:[~2007-10-27  3:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-26  6:48 [PATCH 0/2] Japanese translation of Documentation/SubmittingPatches Keiichi KII
2007-10-26  6:51 ` [PATCH 1/2] fix typo in SubmittingPatches Keiichi KII
2007-10-27  3:50   ` Randy Dunlap [this message]
2007-10-29 10:50     ` Keiichi KII
2007-10-29 10:51   ` Keiichi KII
2007-10-26  6:55 ` [PATCH 2/2] add SubmittingPatches to Documentation/ja_JP Keiichi KII
2007-10-26  7:12   ` YOSHIFUJI Hideaki / 吉藤英明
2007-10-26 11:48     ` Keiichi KII

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071026205009.24ec2d83.randy.dunlap@oracle.com \
    --to=randy.dunlap@oracle.com \
    --cc=apw@shadowen.org \
    --cc=gregkh@suse.de \
    --cc=k-keiichi@bx.jp.nec.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox