From: Al Viro <viro@ftp.linux.org.uk>
To: Shannon Nelson <shannon.nelson@intel.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
greg@kroah.com, hskinnemoen@atmel.com, dan.j.williams@intel.com
Subject: Re: [PATCH] DMAENGINE: too many kref_put calls
Date: Sat, 27 Oct 2007 07:40:29 +0100 [thread overview]
Message-ID: <20071027064029.GM8181@ftp.linux.org.uk> (raw)
In-Reply-To: <20071026235648.5737.45405.stgit@localhost.localdomain>
On Fri, Oct 26, 2007 at 04:56:48PM -0700, Shannon Nelson wrote:
> static void dma_dev_release(struct device *dev)
> {
> - struct dma_chan *chan = to_dma_chan(dev);
> - kref_put(&chan->device->refcount, dma_async_device_cleanup);
> + return;
> }
Practically guaranteed to be broken. Empty ->release() is almost certain
to mean that you can get operations on already freed object.
next prev parent reply other threads:[~2007-10-27 6:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-26 23:56 [PATCH] DMAENGINE: too many kref_put calls Shannon Nelson
2007-10-27 6:40 ` Al Viro [this message]
2007-10-27 13:28 ` Haavard Skinnemoen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071027064029.GM8181@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=greg@kroah.com \
--cc=hskinnemoen@atmel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shannon.nelson@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox