From: Adrian Bunk <bunk@kernel.org>
To: KaiGai Kohei <kaigai@ak.jp.nec.com>,
David Woodhouse <dwmw2@infradead.org>
Cc: jffs-dev@axis.com, linux-kernel@vger.kernel.org
Subject: jffs2_init_acl_post() can return uninitialized variable
Date: Sat, 27 Oct 2007 16:18:42 +0200 [thread overview]
Message-ID: <20071027141842.GV30533@stusta.de> (raw)
Commit cfc8dc6f6f69ede939e09c2af06a01adee577285 added the following
function that can return the value of an uninitialized variable:
<-- snip -->
...
int jffs2_init_acl_post(struct inode *inode)
{
struct jffs2_inode_info *f = JFFS2_INODE_INFO(inode);
int rc;
if (f->i_acl_default) {
rc = __jffs2_set_acl(inode, JFFS2_XPREFIX_ACL_DEFAULT, f->i_acl_default);
if (rc)
return rc;
}
if (f->i_acl_access) {
rc = __jffs2_set_acl(inode, JFFS2_XPREFIX_ACL_ACCESS, f->i_acl_access);
if (rc)
return rc;
}
return rc;
}
...
<-- snip -->
Spotted by the Coverity checker.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next reply other threads:[~2007-10-27 14:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-27 14:18 Adrian Bunk [this message]
2007-10-27 14:42 ` jffs2_init_acl_post() can return uninitialized variable David Woodhouse
2007-10-27 14:47 ` [Git Patch]fs/jffs2/acl.c: Fix a may-be-uninitialized return value WANG Cong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071027141842.GV30533@stusta.de \
--to=bunk@kernel.org \
--cc=dwmw2@infradead.org \
--cc=jffs-dev@axis.com \
--cc=kaigai@ak.jp.nec.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox