[2.6 patch] OSS msnd: fix array overflows

[2.6 patch] OSS msnd: fix array overflows

[Adrian Bunk]

This patch fixes array overflows in the OSS msnd driver spotted by the 
Coverity checker.

Signed-off-by: Adrian Bunk <bunk@kernel.org>

---
97463a59dfb9ccb915d3b615225c98cb3e310c0a 
diff --git a/sound/oss/msnd.h b/sound/oss/msnd.h
index 05cf786..d0ca582 100644
--- a/sound/oss/msnd.h
+++ b/sound/oss/msnd.h
@@ -233,8 +233,8 @@ typedef struct multisound_dev {
 	spinlock_t lock;
 	int nresets;
 	unsigned long recsrc;
-	int left_levels[16];
-	int right_levels[16];
+	int left_levels[32];
+	int right_levels[32];
 	int mixer_mod_count;
 	int calibrate_signal;
 	int play_sample_size, play_sample_rate, play_channels;

[2.6 patch] OSS msnd: fix array overflows

[Adrian Bunk]

This patch fixes array overflows in the OSS msnd driver spotted by the 
Coverity checker.

Signed-off-by: Adrian Bunk <bunk@kernel.org>

---

This patch has been sent on:
- 27 Oct 2007

97463a59dfb9ccb915d3b615225c98cb3e310c0a 
diff --git a/sound/oss/msnd.h b/sound/oss/msnd.h
index 05cf786..d0ca582 100644
--- a/sound/oss/msnd.h
+++ b/sound/oss/msnd.h
@@ -233,8 +233,8 @@ typedef struct multisound_dev {
 	spinlock_t lock;
 	int nresets;
 	unsigned long recsrc;
-	int left_levels[16];
-	int right_levels[16];
+	int left_levels[32];
+	int right_levels[32];
 	int mixer_mod_count;
 	int calibrate_signal;
 	int play_sample_size, play_sample_rate, play_channels;

Re: [2.6 patch] OSS msnd: fix array overflows

[Oliver Pinter (Pintér Olivér)]

then it is auch to 2.6.22-stable?

On 1/1/08, Adrian Bunk <bunk@kernel.org> wrote:
> This patch fixes array overflows in the OSS msnd driver spotted by the
> Coverity checker.
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
>
> ---
>
> This patch has been sent on:
> - 27 Oct 2007
>
> 97463a59dfb9ccb915d3b615225c98cb3e310c0a
> diff --git a/sound/oss/msnd.h b/sound/oss/msnd.h
> index 05cf786..d0ca582 100644
> --- a/sound/oss/msnd.h
> +++ b/sound/oss/msnd.h
> @@ -233,8 +233,8 @@ typedef struct multisound_dev {
>  	spinlock_t lock;
>  	int nresets;
>  	unsigned long recsrc;
> -	int left_levels[16];
> -	int right_levels[16];
> +	int left_levels[32];
> +	int right_levels[32];
>  	int mixer_mod_count;
>  	int calibrate_signal;
>  	int play_sample_size, play_sample_rate, play_channels;
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>


-- 
Thanks,
Oliver

Re: [2.6 patch] OSS msnd: fix array overflows

[Adrian Bunk]

On Tue, Jan 01, 2008 at 07:43:23PM +0100, Oliver Pinter (Pintér Olivér) wrote:
> then it is auch to 2.6.22-stable?

That's a very old bug in a driver for ancient hardware, so there's no 
need to hurry.

> On 1/1/08, Adrian Bunk <bunk@kernel.org> wrote:
> > This patch fixes array overflows in the OSS msnd driver spotted by the
> > Coverity checker.
> >
> > Signed-off-by: Adrian Bunk <bunk@kernel.org>
> >
> > ---
> >
> > This patch has been sent on:
> > - 27 Oct 2007
> >
> > 97463a59dfb9ccb915d3b615225c98cb3e310c0a
> > diff --git a/sound/oss/msnd.h b/sound/oss/msnd.h
> > index 05cf786..d0ca582 100644
> > --- a/sound/oss/msnd.h
> > +++ b/sound/oss/msnd.h
> > @@ -233,8 +233,8 @@ typedef struct multisound_dev {
> >  	spinlock_t lock;
> >  	int nresets;
> >  	unsigned long recsrc;
> > -	int left_levels[16];
> > -	int right_levels[16];
> > +	int left_levels[32];
> > +	int right_levels[32];
> >  	int mixer_mod_count;
> >  	int calibrate_signal;
> >  	int play_sample_size, play_sample_rate, play_channels;
> 
> Thanks,
> Oliver

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed