Re: Stringbuf, v2

Matthew Wilcox
2007-10-24T21:34:51Z

On Wed, Oct 24, 2007 at 02:06:33PM -0700, Joe Perches wrote:
> On Wed, 2007-10-24 at 14:57 -0600, Matthew Wilcox wrote:
> > If you look at the patches, you'll see that they basically all have a
> > wrapper around sb_printf that I was able to insert the GFP argument
> > into, so I don't see this as a win.
>
> I was hoping that each module/subsystem would not need a
> separate wrapper and could use the plain sb_printf function.

Then they should carefully think about whether they need GFP_ATOMIC or
GFP_KERNEL. Just like we don't have a kalloc() that uses GFP_ATOMIC
to spare people from having to think about it.

ISDN and sound had done that thinking for me -- one knew they needed
GFP_ATOMIC, the other needed GFP_KERNEL. I was able to work out that
GFP_KERNEL made sense for the partition code.

--
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."