Re: [patch 08/10] SLUB: Optional fast path using cmpxchg_local

Christoph Lameter
2007-10-29T03:34:23Z

On Sun, 28 Oct 2007, Pekka J Enberg wrote:

> - local_irq_restore(flags);
> + object = do_slab_alloc(s, c, gfpflags, node, addr);
> + if (unlikely(!object))
> + goto out;

Undoing the optimization that one of the earlier patches added.

The #ifdef version is for me at least easier to read. The code there is a
special unit that has to deal with the most performance critical piece of
the slab allocator. And the #ifdef there clarifies that any changes have
to be done to both branches.