From: Matthew Wilcox <matthew@wil.cx>
To: Adrian Bunk <bunk@kernel.org>
Cc: James.Bottomley@SteelEye.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] scsi/seagate.c: remove dead code
Date: Sun, 28 Oct 2007 09:53:54 -0600 [thread overview]
Message-ID: <20071028155354.GJ27248@parisc-linux.org> (raw)
In-Reply-To: <20071028155142.GB7227@stusta.de>
On Sun, Oct 28, 2007 at 04:51:42PM +0100, Adrian Bunk wrote:
> This patch removes obviously dead code.
> case LINKED_WRONG:
> WRITE_DATA (ABORT);
> linked_connected = 0;
> reselect = CAN_RECONNECT;
> goto connect_loop;
> - DPRINTK (PHASE_MSGOUT | DEBUG_LINKED, "scsi%d : sent ABORT message to cancel incorrect I_T_L nexus.\n", hostno);
> #endif /* LINKED */
> - DPRINTK (DEBUG_LINKED, "correct\n");
> default:
Surely the 'goto' should just be moved two lines down?
--
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
next prev parent reply other threads:[~2007-10-28 15:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-28 15:51 [2.6 patch] scsi/seagate.c: remove dead code Adrian Bunk
2007-10-28 15:53 ` Matthew Wilcox [this message]
2007-10-29 9:44 ` Boaz Harrosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071028155354.GJ27248@parisc-linux.org \
--to=matthew@wil.cx \
--cc=James.Bottomley@SteelEye.com \
--cc=bunk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox