public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ciaran McCreesh <ciaran.mccreesh@blueyonder.co.uk>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Abit F-190HD Onboard rlt8169 Ethernet Controller
Date: Mon, 29 Oct 2007 08:49:49 +0000	[thread overview]
Message-ID: <20071029084949.19d20323@snowcone> (raw)
In-Reply-To: <20071029083333.18a4dab7@the-village.bc.nu>

[-- Attachment #1: Type: text/plain, Size: 649 bytes --]

On Mon, 29 Oct 2007 08:33:33 +0000
Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> > It is not recognised by 2.6.24-rc1. I'm guessing it's because the
> > vendor ID is 0001 rather than something sensible. I patched the
> > kernel as follows:
> 
> A vendor ID of 1 is very very very broken. Do all boards have this or
> do you have a faulty box (perhaps a misprogrammed EEPROM somewhere)

A Google for 0001:8168 finds other mentions of the same board. Looks
like it's a general problem.

> That will match any device 0x8168 not just a realtek one. I'd use
> 0x0001, 0x8168 for the match.

Ok. I've attached an updated patch.

Thanks,
-- 
Ciaran McCreesh

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: f-190hd-rlt8139.patch --]
[-- Type: text/x-patch; name=f-190hd-rlt8139.patch, Size: 598 bytes --]

--- drivers/net/r8169.c.orig	2007-10-29 05:37:02.000000000 +0000
+++ drivers/net/r8169.c	2007-10-29 08:46:24.000000000 +0000
@@ -165,6 +165,7 @@
 	{ PCI_DEVICE(PCI_VENDOR_ID_REALTEK,	0x8136), 0, 0, RTL_CFG_2 },
 	{ PCI_DEVICE(PCI_VENDOR_ID_REALTEK,	0x8167), 0, 0, RTL_CFG_0 },
 	{ PCI_DEVICE(PCI_VENDOR_ID_REALTEK,	0x8168), 0, 0, RTL_CFG_1 },
+	{ PCI_DEVICE(0x0001,			0x8168), 0, 0, RTL_CFG_2 },
 	{ PCI_DEVICE(PCI_VENDOR_ID_REALTEK,	0x8169), 0, 0, RTL_CFG_0 },
 	{ PCI_DEVICE(PCI_VENDOR_ID_DLINK,	0x4300), 0, 0, RTL_CFG_0 },
 	{ PCI_DEVICE(PCI_VENDOR_ID_AT,		0xc107), 0, 0, RTL_CFG_0 },

  parent reply	other threads:[~2007-10-29  8:50 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-29  6:15 Abit F-190HD Onboard rlt8169 Ethernet Controller Ciaran McCreesh
2007-10-29  8:33 ` Alan Cox
2007-10-29  8:42   ` Jeff Garzik
2007-10-29 12:00     ` Francois Romieu
2007-10-30  0:27       ` Ciaran McCreesh
2007-10-30 22:59         ` Francois Romieu
2007-10-30 23:49           ` Ciaran McCreesh
2007-10-29  8:49   ` Ciaran McCreesh [this message]
2007-11-01 16:17   ` Josh Logan
2007-11-01 21:53     ` Francois Romieu
2007-11-02  0:05       ` Ciaran McCreesh
2007-11-07  5:21       ` Josh Logan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071029084949.19d20323@snowcone \
    --to=ciaran.mccreesh@blueyonder.co.uk \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox