[PATCH] sound/ad1848: fix printk format

[PATCH] sound/ad1848: fix printk format

[Randy Dunlap]

From: Randy Dunlap <randy.dunlap@oracle.com>

Fix printk format warning:

sound/isa/ad1848/ad1848_lib.c:216: warning: format '%d' expects type 'int', but argument 4 has type 'long unsigned int'

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
 sound/isa/ad1848/ad1848_lib.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-2624-rc1g4-v1.orig/sound/isa/ad1848/ad1848_lib.c
+++ linux-2624-rc1g4-v1/sound/isa/ad1848/ad1848_lib.c
@@ -213,7 +213,7 @@ static void snd_ad1848_mce_down(struct s
 	for (timeout = 12000; timeout > 0 && (inb(AD1848P(chip, REGSEL)) & AD1848_INIT); timeout--)
 		udelay(100);
 
-	snd_printdd("(1) timeout = %d\n", timeout);
+	snd_printdd("(1) timeout = %lu\n", timeout);
 
 #ifdef CONFIG_SND_DEBUG
 	if (inb(AD1848P(chip, REGSEL)) & AD1848_INIT)

Re: [PATCH] sound/ad1848: fix printk format

[Takashi Iwai]

At Mon, 29 Oct 2007 11:20:10 -0700,
Randy Dunlap wrote:
> 
> From: Randy Dunlap <randy.dunlap@oracle.com>
> 
> Fix printk format warning:
> 
> sound/isa/ad1848/ad1848_lib.c:216: warning: format '%d' expects type 'int', but argument 4 has type 'long unsigned int'
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>

Thanks, but another fix was already in ALSA tree.

Jaroslav, please prepare for push again?  Some patches are really
worth to be in 2.6.24.


Takashi

> ---
>  sound/isa/ad1848/ad1848_lib.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- linux-2624-rc1g4-v1.orig/sound/isa/ad1848/ad1848_lib.c
> +++ linux-2624-rc1g4-v1/sound/isa/ad1848/ad1848_lib.c
> @@ -213,7 +213,7 @@ static void snd_ad1848_mce_down(struct s
>  	for (timeout = 12000; timeout > 0 && (inb(AD1848P(chip, REGSEL)) & AD1848_INIT); timeout--)
>  		udelay(100);
>  
> -	snd_printdd("(1) timeout = %d\n", timeout);
> +	snd_printdd("(1) timeout = %lu\n", timeout);
>  
>  #ifdef CONFIG_SND_DEBUG
>  	if (inb(AD1848P(chip, REGSEL)) & AD1848_INIT)
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 

Re: [PATCH] sound/ad1848: fix printk format

[Randy Dunlap]

On Tue, 30 Oct 2007 12:05:28 +0100 Takashi Iwai wrote:

> At Mon, 29 Oct 2007 11:20:10 -0700,
> Randy Dunlap wrote:
> > 
> > From: Randy Dunlap <randy.dunlap@oracle.com>
> > 
> > Fix printk format warning:
> > 
> > sound/isa/ad1848/ad1848_lib.c:216: warning: format '%d' expects type 'int', but argument 4 has type 'long unsigned int'
> > 
> > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> 
> Thanks, but another fix was already in ALSA tree.
> 
> Jaroslav, please prepare for push again?  Some patches are really
> worth to be in 2.6.24.

Hi,
This is still needed, over 1 month later....


> Takashi
> 
> > ---
> >  sound/isa/ad1848/ad1848_lib.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > --- linux-2624-rc1g4-v1.orig/sound/isa/ad1848/ad1848_lib.c
> > +++ linux-2624-rc1g4-v1/sound/isa/ad1848/ad1848_lib.c
> > @@ -213,7 +213,7 @@ static void snd_ad1848_mce_down(struct s
> >  	for (timeout = 12000; timeout > 0 && (inb(AD1848P(chip, REGSEL)) & AD1848_INIT); timeout--)
> >  		udelay(100);
> >  
> > -	snd_printdd("(1) timeout = %d\n", timeout);
> > +	snd_printdd("(1) timeout = %lu\n", timeout);
> >  
> >  #ifdef CONFIG_SND_DEBUG
> >  	if (inb(AD1848P(chip, REGSEL)) & AD1848_INIT)
> > -


---
~Randy

Re: [PATCH] sound/ad1848: fix printk format

[Takashi Iwai]

At Wed, 12 Dec 2007 20:42:46 -0800,
Randy Dunlap wrote:
> 
> On Tue, 30 Oct 2007 12:05:28 +0100 Takashi Iwai wrote:
> 
> > At Mon, 29 Oct 2007 11:20:10 -0700,
> > Randy Dunlap wrote:
> > > 
> > > From: Randy Dunlap <randy.dunlap@oracle.com>
> > > 
> > > Fix printk format warning:
> > > 
> > > sound/isa/ad1848/ad1848_lib.c:216: warning: format '%d' expects type 'int', but argument 4 has type 'long unsigned int'
> > > 
> > > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> > 
> > Thanks, but another fix was already in ALSA tree.
> > 
> > Jaroslav, please prepare for push again?  Some patches are really
> > worth to be in 2.6.24.
> 
> Hi,
> This is still needed, over 1 month later....

Thanks for notice.  It's in the alsa.git tree but it's slipped from
the last push...


Jaroslav, could you make it for push please?


thanks,

Takashi

> 
> 
> > Takashi
> > 
> > > ---
> > >  sound/isa/ad1848/ad1848_lib.c |    2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > --- linux-2624-rc1g4-v1.orig/sound/isa/ad1848/ad1848_lib.c
> > > +++ linux-2624-rc1g4-v1/sound/isa/ad1848/ad1848_lib.c
> > > @@ -213,7 +213,7 @@ static void snd_ad1848_mce_down(struct s
> > >  	for (timeout = 12000; timeout > 0 && (inb(AD1848P(chip, REGSEL)) & AD1848_INIT); timeout--)
> > >  		udelay(100);
> > >  
> > > -	snd_printdd("(1) timeout = %d\n", timeout);
> > > +	snd_printdd("(1) timeout = %lu\n", timeout);
> > >  
> > >  #ifdef CONFIG_SND_DEBUG
> > >  	if (inb(AD1848P(chip, REGSEL)) & AD1848_INIT)
> > > -
> 
> 
> ---
> ~Randy
>