From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753796AbXJ2LWl (ORCPT ); Mon, 29 Oct 2007 07:22:41 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751981AbXJ2LWd (ORCPT ); Mon, 29 Oct 2007 07:22:33 -0400 Received: from e5.ny.us.ibm.com ([32.97.182.145]:60256 "EHLO e5.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751141AbXJ2LWc (ORCPT ); Mon, 29 Oct 2007 07:22:32 -0400 Date: Mon, 29 Oct 2007 16:52:28 +0530 From: Kamalesh Babulal To: Jens Axboe Cc: linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, linux-s390@vger.kernel.org Subject: [PATCH-RESEND] Re: S390 change in sg_set_page() cause build failure Message-ID: <20071029112228.GA29163@linux.vnet.ibm.com> Reply-To: Kamalesh Babulal References: <20071026111945.GB21274@linux.vnet.ibm.com> <20071026115429.GH5155@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20071026115429.GH5155@kernel.dk> User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 26, 2007 at 01:54:30PM +0200, Jens Axboe wrote: > On Fri, Oct 26 2007, Kamalesh Babulal wrote: > > Hi Jens, > > > > sg_set_buf(list, address, 0); > > } > > That's not quite right, it should be: > > diff --git a/drivers/s390/scsi/zfcp_def.h b/drivers/s390/scsi/zfcp_def.h > index 0754542..e268f79 100644 > --- a/drivers/s390/scsi/zfcp_def.h > +++ b/drivers/s390/scsi/zfcp_def.h > @@ -70,11 +70,12 @@ zfcp_sg_to_address(struct scatterlist *list) > * zfcp_address_to_sg - set up struct scatterlist from kernel address > * @address: kernel address > * @list: struct scatterlist > + * @size: buffer size > */ > static inline void > -zfcp_address_to_sg(void *address, struct scatterlist *list) > +zfcp_address_to_sg(void *address, struct scatterlist *list, unsigned int size) > { > - sg_set_buf(list, address, 0); > + sg_set_buf(list, address, size); > } > > #define REQUEST_LIST_SIZE 128 > > -- > Jens Axboe Hi Jens, Resending the patch with the changes pointed by you in the patch. [jens.axboe@oracle.com: size parameter fix] Signed-off-by: Kamalesh Babulal -- diff --git a/drivers/s390/scsi/zfcp_def.h b/drivers/s390/scsi/zfcp_def.h index 0754542..f747e86 100644 --- a/drivers/s390/scsi/zfcp_def.h +++ b/drivers/s390/scsi/zfcp_def.h @@ -70,11 +70,12 @@ zfcp_sg_to_address(struct scatterlist *list) * zfcp_address_to_sg - set up struct scatterlist from kernel address * @address: kernel address * @list: struct scatterlist + * @size: buffer size */ static inline void -zfcp_address_to_sg(void *address, struct scatterlist *list) +zfcp_address_to_sg(void *address, struct scatterlist *list, unsigned int size) { - sg_set_buf(list, address, 0); + sg_set_buf(list, address, size); } #define REQUEST_LIST_SIZE 128 -- Thanks & Regards, Kamalesh Babulal, Linux Technology Center, IBM,ISTL.