From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753311AbXJ2L2t (ORCPT ); Mon, 29 Oct 2007 07:28:49 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752020AbXJ2L2l (ORCPT ); Mon, 29 Oct 2007 07:28:41 -0400 Received: from brick.kernel.dk ([87.55.233.238]:24674 "EHLO kernel.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751211AbXJ2L2k (ORCPT ); Mon, 29 Oct 2007 07:28:40 -0400 Date: Mon, 29 Oct 2007 12:26:18 +0100 From: Jens Axboe To: Kamalesh Babulal Cc: linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, akpm@linux-foundation.org, linux-s390@vger.kernel.org Subject: Re: [PATCH-RESEND] Re: S390 change in sg_set_page() cause build failure Message-ID: <20071029112617.GB5001@kernel.dk> References: <20071026111945.GB21274@linux.vnet.ibm.com> <20071026115429.GH5155@kernel.dk> <20071029112228.GA29163@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20071029112228.GA29163@linux.vnet.ibm.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 29 2007, Kamalesh Babulal wrote: > On Fri, Oct 26, 2007 at 01:54:30PM +0200, Jens Axboe wrote: > > On Fri, Oct 26 2007, Kamalesh Babulal wrote: > > > Hi Jens, > > > > > > sg_set_buf(list, address, 0); > > > > } > > > > That's not quite right, it should be: > > > > diff --git a/drivers/s390/scsi/zfcp_def.h b/drivers/s390/scsi/zfcp_def.h > > index 0754542..e268f79 100644 > > --- a/drivers/s390/scsi/zfcp_def.h > > +++ b/drivers/s390/scsi/zfcp_def.h > > @@ -70,11 +70,12 @@ zfcp_sg_to_address(struct scatterlist *list) > > * zfcp_address_to_sg - set up struct scatterlist from kernel address > > * @address: kernel address > > * @list: struct scatterlist > > + * @size: buffer size > > */ > > static inline void > > -zfcp_address_to_sg(void *address, struct scatterlist *list) > > +zfcp_address_to_sg(void *address, struct scatterlist *list, unsigned int size) > > { > > - sg_set_buf(list, address, 0); > > + sg_set_buf(list, address, size); > > } > > > > #define REQUEST_LIST_SIZE 128 > > > > -- > > Jens Axboe > > Hi Jens, > > Resending the patch with the changes pointed by you in the patch. > > [jens.axboe@oracle.com: size parameter fix] > Signed-off-by: Kamalesh Babulal > -- > diff --git a/drivers/s390/scsi/zfcp_def.h b/drivers/s390/scsi/zfcp_def.h > index 0754542..f747e86 100644 > --- a/drivers/s390/scsi/zfcp_def.h > +++ b/drivers/s390/scsi/zfcp_def.h > @@ -70,11 +70,12 @@ zfcp_sg_to_address(struct scatterlist *list) > * zfcp_address_to_sg - set up struct scatterlist from kernel address > * @address: kernel address > * @list: struct scatterlist > + * @size: buffer size > */ > static inline void > -zfcp_address_to_sg(void *address, struct scatterlist *list) > +zfcp_address_to_sg(void *address, struct scatterlist *list, unsigned int size) > { > - sg_set_buf(list, address, 0); > + sg_set_buf(list, address, size); > } > > #define REQUEST_LIST_SIZE 128 Thanks Kamalesh, but I already merged a fixed up version on friday: http://git.kernel.dk/?p=linux-2.6-block.git;a=commit;h=9335432959111c982c74177521305e6a3fb600a3 -- Jens Axboe