From: Jeff Dike <jdike@addtoit.com>
To: WANG Cong <xiyou.wangcong@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
user-mode-linux-devel@lists.sourceforge.net,
Andrew Morton <akpm@osdl.org>
Subject: Re: [Git Patch] arch/um/os-Linux/: varied improvements and fixes
Date: Mon, 29 Oct 2007 12:55:29 -0400 [thread overview]
Message-ID: <20071029165529.GA6055@c2.user-mode-linux.org> (raw)
In-Reply-To: <20071028073843.GD2502@hacking>
On Sun, Oct 28, 2007 at 03:38:43PM +0800, WANG Cong wrote:
> This patch contains varied fixes and improvements for some files under
> arch/um/os-Linux/, such as a typo fix in a perror message, a missing
> argument fix for a printf, some constifying for pointers and so on.
Generally looks good, thanks.
> printf("failed to install handler for signal %d - errno = %d\n",
> - errno);
> + sig, errno);
Nice spotting - I wonder why gcc didn't complain about this.
> - sigprocmask(on ? SIG_UNBLOCK : SIG_BLOCK, &sigset, &old);
> + if (sigprocmask(on ? SIG_UNBLOCK : SIG_BLOCK, &sigset, &old) < 0)
> + return -1;
In cases like this, I return -errno, not -1. I'll fix this up.
Jeff
--
Work email - jdike at linux dot intel dot com
prev parent reply other threads:[~2007-10-29 16:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-28 7:38 [Git Patch] arch/um/os-Linux/: varied improvements and fixes WANG Cong
2007-10-29 16:55 ` Jeff Dike [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071029165529.GA6055@c2.user-mode-linux.org \
--to=jdike@addtoit.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=user-mode-linux-devel@lists.sourceforge.net \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox