Re: [PATCH] audit: clear thread flag for new children

Tony Jones
2007-10-29T23:17:21Z

On Mon, Oct 29, 2007 at 06:04:31PM -0400, Steve Grubb wrote:

> If the child does not have the TIF_SYSCALL_AUDIT flag, it never goes into
> audit_syscall_entry. It becomes unauditable.

True but a task where current->audit_context == NULL is going to immediately
BUG out in audit_syscall_entry. This is why the invocations of
audit_syscall_entry() are conditional on current->audit_context.

> So when audit is re-enabled, how do you make that task auditable?

No idea. How do you do it currently? HINT: current->audit_context == NULL
for these tasks. If !audit_enabled, then audit_alloc() is not going to
allocate an audit_context for the task.

I'm very curious how you think one of these tasks becomes auditable later
on once audit is re-enabled, regardless of the value of TIF_SYSCALL_AUDIT.

Tony