From: Jens Axboe <jens.axboe@oracle.com>
To: "Robert P. J. Day" <rpjday@crashcourse.ca>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
gorcunov@gmail.com
Subject: Re: [PATCH] Clean up scatterlist.h and introduce macros for readability.
Date: Mon, 29 Oct 2007 19:58:04 +0100 [thread overview]
Message-ID: <20071029185803.GA7499@kernel.dk> (raw)
In-Reply-To: <Pine.LNX.4.64.0710291234560.20259@localhost.localdomain>
On Mon, Oct 29 2007, Robert P. J. Day wrote:
>
> Add some macros to <linux/scatterlist.h> to make the bit manipulation
> more readable, and expand on some of the documentation.
>
> This patch incorporates content from Cyrill Gorcunov
> <gorcunov@gmail.com> as well.
I don't like it, I already explained why I don't consider the 'magic'
values a problem. The use of the bits is supposed to be scatterlist.h
private and the values are documented at the top of that include file.
--
Jens Axboe
next prev parent reply other threads:[~2007-10-29 18:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-29 17:04 [PATCH] Clean up scatterlist.h and introduce macros for readability Robert P. J. Day
2007-10-29 17:30 ` Cyrill Gorcunov
2007-10-29 18:58 ` Jens Axboe [this message]
2007-10-29 20:20 ` Cyrill Gorcunov
2007-10-29 20:23 ` Jens Axboe
2007-10-29 20:37 ` Randy Dunlap
2007-10-30 11:44 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071029185803.GA7499@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=gorcunov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rpjday@crashcourse.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox