[PATCH]: linux/interrupt.h doesn't need sched.h

[PATCH]: linux/interrupt.h doesn't need sched.h

[Arnaldo Carvalho de Melo]

Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

diff --git a/include/linux/interrupt.h b/include/linux/interrupt.h
index 2306920..5a0fc81 100644
--- a/include/linux/interrupt.h
+++ b/include/linux/interrupt.h
@@ -9,7 +9,6 @@
 #include <linux/cpumask.h>
 #include <linux/irqreturn.h>
 #include <linux/hardirq.h>
-#include <linux/sched.h>
 #include <linux/irqflags.h>
 #include <asm/atomic.h>
 #include <asm/ptrace.h>

Re: [PATCH]: linux/interrupt.h doesn't need sched.h

[Alexey Dobriyan]

On Mon, Oct 29, 2007 at 11:45:39AM -0200, Arnaldo Carvalho de Melo wrote:
> --- a/include/linux/interrupt.h
> +++ b/include/linux/interrupt.h
> @@ -9,7 +9,6 @@
>  #include <linux/cpumask.h>
>  #include <linux/irqreturn.h>
>  #include <linux/hardirq.h>
> -#include <linux/sched.h>
>  #include <linux/irqflags.h>
>  #include <asm/atomic.h>
>  #include <asm/ptrace.h>

ACK the part that nothing needs sched.h, but it shouldn't change anything,
because of interrupt.h => hardirq.h => smp_lock.h => sched.h dependency.

[puts patch on cross-compile farm anyway]
[starts finding scalpels]

Re: [PATCH]: linux/interrupt.h doesn't need sched.h

[Alexey Dobriyan]

On Mon, Oct 29, 2007 at 09:12:10PM +0300,  wrote:
> On Mon, Oct 29, 2007 at 11:45:39AM -0200, Arnaldo Carvalho de Melo wrote:
> > --- a/include/linux/interrupt.h
> > +++ b/include/linux/interrupt.h
> > @@ -9,7 +9,6 @@
> >  #include <linux/cpumask.h>
> >  #include <linux/irqreturn.h>
> >  #include <linux/hardirq.h>
> > -#include <linux/sched.h>
> >  #include <linux/irqflags.h>
> >  #include <asm/atomic.h>
> >  #include <asm/ptrace.h>
> 
> ACK the part that nothing needs sched.h, but it shouldn't change anything,
> because of interrupt.h => hardirq.h => smp_lock.h => sched.h dependency.
> 
> [puts patch on cross-compile farm anyway]
> [starts finding scalpels]

Actually, NAK as-is. It immediately breaks on x86_64-allnoconfig et al.
I'll send updated version :)

Re: [PATCH]: linux/interrupt.h doesn't need sched.h

[Arnaldo Carvalho de Melo]

Em Mon, Oct 29, 2007 at 09:12:10PM +0300, Alexey Dobriyan escreveu:
> On Mon, Oct 29, 2007 at 11:45:39AM -0200, Arnaldo Carvalho de Melo wrote:
> > --- a/include/linux/interrupt.h
> > +++ b/include/linux/interrupt.h
> > @@ -9,7 +9,6 @@
> >  #include <linux/cpumask.h>
> >  #include <linux/irqreturn.h>
> >  #include <linux/hardirq.h>
> > -#include <linux/sched.h>
> >  #include <linux/irqflags.h>
> >  #include <asm/atomic.h>
> >  #include <asm/ptrace.h>
> 
> ACK the part that nothing needs sched.h, but it shouldn't change anything,
> because of interrupt.h => hardirq.h => smp_lock.h => sched.h dependency.

Yeah, but one thing at a time, now its one link in the maze, before it
was two :-)
 
> [puts patch on cross-compile farm anyway]
> [starts finding scalpels]

Thanks!

- Arnaldo

Re: [PATCH]: linux/interrupt.h doesn't need sched.h

[Alexey Dobriyan]

On Mon, Oct 29, 2007 at 05:08:46PM -0200, Arnaldo Carvalho de Melo wrote:
> Em Mon, Oct 29, 2007 at 09:12:10PM +0300, Alexey Dobriyan escreveu:
> > On Mon, Oct 29, 2007 at 11:45:39AM -0200, Arnaldo Carvalho de Melo wrote:
> > > --- a/include/linux/interrupt.h
> > > +++ b/include/linux/interrupt.h
> > > @@ -9,7 +9,6 @@
> > >  #include <linux/cpumask.h>
> > >  #include <linux/irqreturn.h>
> > >  #include <linux/hardirq.h>
> > > -#include <linux/sched.h>
> > >  #include <linux/irqflags.h>
> > >  #include <asm/atomic.h>
> > >  #include <asm/ptrace.h>
> > 
> > ACK the part that nothing needs sched.h, but it shouldn't change anything,
> > because of interrupt.h => hardirq.h => smp_lock.h => sched.h dependency.
> 
> Yeah, but one thing at a time, now its one link in the maze, before it
> was two :-)
>  
> > [puts patch on cross-compile farm anyway]
> > [starts finding scalpels]

Argh!

interrupt.h contains sti().
sti() on m68k wants hardirq_count().
hardirq_count() wants preempt_count();
preempt_count() wants current_thread_info()
current_thread_info() on m68k wants task_thread_info()
task_thread_info() on m68k is

	(&(tsk)->thread.info)

We're screwed, because adding sched.h to asm-m68k/thread_info.h leads to
even more horrible things.

Comments? Well, apart from "our header dependencies suck" and "let's add
CONFIG_M^*K to interrupt.h".