Re: [PATCH] Only show RESOURCES_64BIT on relevant architectures

Ralf Baechle
2007-10-30T14:14:22Z

On Tue, Oct 30, 2007 at 06:13:16AM -0600, Matthew Wilcox wrote:

> > On Tue, Oct 30, 2007 at 02:37:19AM -0600, Matthew Wilcox wrote:
> > > On Mon, Oct 29, 2007 at 10:03:16PM -0500, Kumar Gala wrote:
> > > > same HW platform that you want to run with just 32-bit phys (for
> > > > performance).
> > >
> > > Have you measured what the performance difference is?
> >
> > So that's 5668, 256 bytes data and 128 bytes of bss for a total of 6052
> > bytes. Not a whole lot but I still fear some users on the most
> > claustrophobic systems will mind.
>
> Oh, sure, I'm not saying I thought there would be no size difference; I
> was just bemused at the suggestion there was a performance difference.
>
> Unless "won't fit in ROM any more" is considered a performance problem ;-)

Linux has traditionally had a paranoid fear of 64-bit datatypes just
because GCC doesn't generate terribly efficient code for i386. I think
that may be the primary reason why CONFIG_RESOURCES_64BIT ever became a
build option. I doubt resource_size_t is being used in any critical
path so the bloat factor will matter much more than the performance
difference it makes. Unless you're terribly impatient waiting for your
PCI bus to complete scan or so ;-)

Ralf