* [PATCH 11/16] CRIS architecture: Correct compile errors
@ 2007-10-30 9:33 Jesper Nilsson
2007-10-30 12:49 ` David Woodhouse
2007-11-06 8:40 ` David Woodhouse
0 siblings, 2 replies; 5+ messages in thread
From: Jesper Nilsson @ 2007-10-30 9:33 UTC (permalink / raw)
To: Andrew Morton, Mikael Starvik, Jesper Nilsson, linux-kernel,
dwmw2
Add include file with prototype for mtdram_init_device from
drivers/mtd/devices/mtdram.c.
Used by axisflashmap.c to boot from ram.
Signed-off-by: Jesper Nilsson <jesper.nilsson@axis.com>
---
mtdram.h | 10 ++++++++++
1 file changed, 10 insertions(+)
--- /dev/null 2007-10-06 06:38:38.348072750 +0200
+++ linux-2.6.23/include/linux/mtd/mtdram.h 2002-11-13 15:57:45.000000000 +0100
@@ -0,0 +1,10 @@
+#ifndef __MTD_MTDRAM_H__
+#define __MTD_MTDRAM_H__
+
+#ifdef __KERNEL__
+#include <linux/mtd/mtd.h>
+int mtdram_init_device(struct mtd_info *mtd, void *mapped_address,
+ unsigned long size, char *name);
+
+#endif /* __KERNEL__ */
+#endif /* __MTD_MTDRAM_H__ */
/^JN - Jesper Nilsson
--
Jesper Nilsson -- jesper.nilsson@axis.com
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 11/16] CRIS architecture: Correct compile errors
2007-10-30 9:33 [PATCH 11/16] CRIS architecture: Correct compile errors Jesper Nilsson
@ 2007-10-30 12:49 ` David Woodhouse
2007-10-30 13:17 ` Jesper Nilsson
2007-11-06 8:40 ` David Woodhouse
1 sibling, 1 reply; 5+ messages in thread
From: David Woodhouse @ 2007-10-30 12:49 UTC (permalink / raw)
To: Jesper Nilsson; +Cc: Andrew Morton, Mikael Starvik, linux-kernel
On Tue, 2007-10-30 at 10:33 +0100, Jesper Nilsson wrote:
> Add include file with prototype for mtdram_init_device from
> drivers/mtd/devices/mtdram.c.
> Used by axisflashmap.c to boot from ram.
>
> Signed-off-by: Jesper Nilsson <jesper.nilsson@axis.com>
Reviewed-by: David Woodhouse <dwmw2@infradead.org>
You want this to go via the mtd git tree, or with the rest of your
patches?
--
dwmw2
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 11/16] CRIS architecture: Correct compile errors
2007-10-30 12:49 ` David Woodhouse
@ 2007-10-30 13:17 ` Jesper Nilsson
0 siblings, 0 replies; 5+ messages in thread
From: Jesper Nilsson @ 2007-10-30 13:17 UTC (permalink / raw)
To: David Woodhouse; +Cc: Andrew Morton, Mikael Starvik, linux-kernel
On Tue, Oct 30, 2007 at 08:49:32AM -0400, David Woodhouse wrote:
>
> On Tue, 2007-10-30 at 10:33 +0100, Jesper Nilsson wrote:
> > Add include file with prototype for mtdram_init_device from
> > drivers/mtd/devices/mtdram.c.
> > Used by axisflashmap.c to boot from ram.
> >
> > Signed-off-by: Jesper Nilsson <jesper.nilsson@axis.com>
>
> Reviewed-by: David Woodhouse <dwmw2@infradead.org>
>
> You want this to go via the mtd git tree, or with the rest of your
> patches?
Whatever is best and/or easiest for you, is probably the answer.
Since this makes the arch compile, it would be good to get it in
soonish, but if you prefer we could go via mtd, which I gather is
the more official route.
> dwmw2
/^JN - Jesper Nilsson
--
Jesper Nilsson -- jesper.nilsson@axis.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 11/16] CRIS architecture: Correct compile errors
2007-10-30 9:33 [PATCH 11/16] CRIS architecture: Correct compile errors Jesper Nilsson
2007-10-30 12:49 ` David Woodhouse
@ 2007-11-06 8:40 ` David Woodhouse
2007-11-06 9:12 ` Jesper Nilsson
1 sibling, 1 reply; 5+ messages in thread
From: David Woodhouse @ 2007-11-06 8:40 UTC (permalink / raw)
To: Jesper Nilsson; +Cc: Andrew Morton, Mikael Starvik, linux-kernel
On Tue, 2007-10-30 at 10:33 +0100, Jesper Nilsson wrote:
> Add include file with prototype for mtdram_init_device from
> drivers/mtd/devices/mtdram.c.
> Used by axisflashmap.c to boot from ram.
>
> Signed-off-by: Jesper Nilsson <jesper.nilsson@axis.com>
>
> ---
> mtdram.h | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> --- /dev/null 2007-10-06 06:38:38.348072750 +0200
> +++ linux-2.6.23/include/linux/mtd/mtdram.h 2002-11-13 15:57:45.000000000 +0100
> @@ -0,0 +1,10 @@
> +#ifndef __MTD_MTDRAM_H__
> +#define __MTD_MTDRAM_H__
> +
> +#ifdef __KERNEL__
> +#include <linux/mtd/mtd.h>
> +int mtdram_init_device(struct mtd_info *mtd, void *mapped_address,
> + unsigned long size, char *name);
> +
> +#endif /* __KERNEL__ */
> +#endif /* __MTD_MTDRAM_H__ */
You don't need #ifdef __KERNEL__ on a file which isn't exported to
userspace. Having removed that, I've applied it to my tree.
--
dwmw2
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 11/16] CRIS architecture: Correct compile errors
2007-11-06 8:40 ` David Woodhouse
@ 2007-11-06 9:12 ` Jesper Nilsson
0 siblings, 0 replies; 5+ messages in thread
From: Jesper Nilsson @ 2007-11-06 9:12 UTC (permalink / raw)
To: David Woodhouse; +Cc: Andrew Morton, Mikael Starvik, linux-kernel
On Tue, Nov 06, 2007 at 08:40:43AM +0000, David Woodhouse wrote:
> You don't need #ifdef __KERNEL__ on a file which isn't exported to
> userspace. Having removed that, I've applied it to my tree.
Ok, thanks, I'll do the same change in our internal CVS.
> dwmw2
/^JN - Jesper Nilsson
--
Jesper Nilsson -- jesper.nilsson@axis.com
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2007-11-06 9:12 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-30 9:33 [PATCH 11/16] CRIS architecture: Correct compile errors Jesper Nilsson
2007-10-30 12:49 ` David Woodhouse
2007-10-30 13:17 ` Jesper Nilsson
2007-11-06 8:40 ` David Woodhouse
2007-11-06 9:12 ` Jesper Nilsson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox