From: Andrew Morton <akpm@linux-foundation.org>
To: Tilman Schmidt <tilman@imap.cc>
Cc: linux-kernel@vger.kernel.org, gregkh@suse.de,
linux-usb-devel@lists.sourceforge.net, hjlipp@web.de,
kkeil@suse.de, i4ldeveloper@listserv.isdn4linux.de
Subject: Re: [PATCH 1/2] usb_gigaset: suspend support [v2]
Date: Tue, 30 Oct 2007 14:01:24 -0700 [thread overview]
Message-ID: <20071030140124.984aba58.akpm@linux-foundation.org> (raw)
In-Reply-To: <20071029214131.70EABFC043@xenon.ts.pxnet.com>
On Mon, 29 Oct 2007 22:41:30 +0100 (CET)
Tilman Schmidt <tilman@imap.cc> wrote:
> From: Tilman Schmidt <tilman@imap.cc>
>
> Add basic suspend/resume support to the usb_gigaset driver.
> (Corrected version.)
>
You're not a big fan of checkpatch, I see.
> +static int gigaset_suspend(struct usb_interface *intf, pm_message_t message)
> +{
> + struct cardstate *cs;
> + struct usb_cardstate *ucs;
> +
> + if ((cs = usb_get_intfdata(intf)) == NULL ||
> + (ucs = cs->hw.usb) == NULL) {
> + err("%s: no cardstate", __func__);
> + return -EFAULT;
> + }
Is the above reeeeeely needed? I bet it never happens.
> +static int gigaset_resume(struct usb_interface *intf)
> +{
> + struct cardstate *cs;
> + struct usb_cardstate *ucs;
> + int rc;
> +
> + if ((cs = usb_get_intfdata(intf)) == NULL ||
> + (ucs = cs->hw.usb) == NULL) {
> + err("%s: no cardstate", __func__);
> + return -EFAULT;
> + }
ditto.
next prev parent reply other threads:[~2007-10-30 21:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20071029185311.4C955FC04C@xenon.ts.pxnet.com>
2007-10-29 19:10 ` [linux-usb-devel] [PATCH 1/2] usb_gigaset: suspend support Alan Stern
2007-10-29 21:20 ` Tilman Schmidt
2007-10-30 8:52 ` Oliver Neukum
2007-11-01 20:17 ` Tilman Schmidt
[not found] ` <20071029214131.70EABFC043@xenon.ts.pxnet.com>
2007-10-30 21:01 ` Andrew Morton [this message]
2007-11-01 18:20 ` [PATCH 1/2] usb_gigaset: suspend support [v2] Tilman Schmidt
2007-11-01 18:45 ` Andrew Morton
2007-11-01 19:47 ` [linux-usb-devel] " Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071030140124.984aba58.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=gregkh@suse.de \
--cc=hjlipp@web.de \
--cc=i4ldeveloper@listserv.isdn4linux.de \
--cc=kkeil@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=tilman@imap.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox