public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Arjan van de Ven <arjan@infradead.org>,
	Robert Hancock <hancockr@shaw.ca>, Greg KH <greg@kroah.com>,
	akpm@linux-foundation.org, ak@suse.de, rajesh.shah@intel.com,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: pci-disable-decode-of-io-memory-during-bar-sizing.patch
Date: Tue, 30 Oct 2007 15:04:35 -0700	[thread overview]
Message-ID: <200710301504.36972.jbarnes@virtuousgeek.org> (raw)
In-Reply-To: <alpine.LFD.0.999.0710300957260.30120@woody.linux-foundation.org>

On Tuesday, October 30, 2007 10:07 am Linus Torvalds wrote:
> (Where "screwed up badly" is the usual "left it to firmware people"
> thing, of course. Dammit, Intel *could* have just made it a real PCI
> BAR in the Northbridge, and specified it as such, and we wouldn't
> have these problems! But no, it had to be another idiotic "firmware
> tells where it is" thing)

The per-device flag is fine with me, but I should make something clear:

MMCONFIG IS NOT BROKEN!

Nor is finding mmconfig space.  We know how to do that too.

What's broken is our PCI probing with certain address space layouts that 
include MMCONFIG space.  Since MMCONFIG is in MMIO space (by 
definition) there will always be the potential for problems when we use 
MMCONFIG and don't disable decode while sizing BARs (probably a latent 
bug on many non-PC Linux platforms).

So we can either use I/O ports for sizing and only switch to MMCONFIG 
later, or we can just use it on an as-needed basis, or we can make our 
PCI probing safe if MMCONFIG is in use.

Jesse

  parent reply	other threads:[~2007-10-30 22:07 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200708151919.l7FJJfUE010966@imap1.linux-foundation.org>
2007-10-25 23:20 ` - mmconfig-validate-against-acpi-motherboard-resources.patch removed from -mm tree Robert Hancock
2007-10-25 23:22   ` Jesse Barnes
2007-10-26  2:54     ` Greg KH
2007-10-26  5:03       ` Robert Hancock
2007-10-26  5:27         ` Greg KH
2007-10-26 16:58           ` Jesse Barnes
2007-10-26 16:59       ` pci-disable-decode-of-io-memory-during-bar-sizing.patch Jesse Barnes
2007-10-27  2:41         ` pci-disable-decode-of-io-memory-during-bar-sizing.patch Greg KH
2007-10-29 23:52           ` pci-disable-decode-of-io-memory-during-bar-sizing.patch Robert Hancock
2007-10-30 15:15             ` pci-disable-decode-of-io-memory-during-bar-sizing.patch Linus Torvalds
2007-10-30 16:47               ` pci-disable-decode-of-io-memory-during-bar-sizing.patch Arjan van de Ven
2007-10-30 17:07                 ` pci-disable-decode-of-io-memory-during-bar-sizing.patch Linus Torvalds
2007-10-30 17:28                   ` pci-disable-decode-of-io-memory-during-bar-sizing.patch Arjan van de Ven
2007-10-30 17:43                     ` pci-disable-decode-of-io-memory-during-bar-sizing.patch Linus Torvalds
2007-11-01  8:31                     ` pci-disable-decode-of-io-memory-during-bar-sizing.patch Martin Mares
2007-11-01 14:08                       ` pci-disable-decode-of-io-memory-during-bar-sizing.patch Arjan van de Ven
2007-11-08 13:50                         ` pci-disable-decode-of-io-memory-during-bar-sizing.patch Martin Mares
2007-10-30 22:04                   ` Jesse Barnes [this message]
2007-10-30 22:22                     ` pci-disable-decode-of-io-memory-during-bar-sizing.patch Linus Torvalds
2007-10-30 22:31                       ` pci-disable-decode-of-io-memory-during-bar-sizing.patch Jesse Barnes
2007-10-30 22:44                         ` pci-disable-decode-of-io-memory-during-bar-sizing.patch David Miller
2007-10-30 22:48                         ` pci-disable-decode-of-io-memory-during-bar-sizing.patch Linus Torvalds
2007-10-30 22:38                       ` pci-disable-decode-of-io-memory-during-bar-sizing.patch Linus Torvalds
2007-10-30 22:39                         ` pci-disable-decode-of-io-memory-during-bar-sizing.patch Jesse Barnes
2007-10-30 23:30                         ` pci-disable-decode-of-io-memory-during-bar-sizing.patch Andi Kleen
2007-10-30 23:41                   ` pci-disable-decode-of-io-memory-during-bar-sizing.patch Robert Hancock
2007-10-30 23:52                     ` pci-disable-decode-of-io-memory-during-bar-sizing.patch Arjan van de Ven
2007-10-31  0:02                       ` pci-disable-decode-of-io-memory-during-bar-sizing.patch Linus Torvalds
2007-10-30 23:59                     ` pci-disable-decode-of-io-memory-during-bar-sizing.patch Linus Torvalds
2007-10-31  0:23                       ` pci-disable-decode-of-io-memory-during-bar-sizing.patch Robert Hancock
2007-10-31  1:30                       ` pci-disable-decode-of-io-memory-during-bar-sizing.patch Jesse Barnes
2007-10-30 18:50               ` pci-disable-decode-of-io-memory-during-bar-sizing.patch Andi Kleen
2007-10-30 19:06                 ` pci-disable-decode-of-io-memory-during-bar-sizing.patch Linus Torvalds
2007-10-30 19:37                   ` pci-disable-decode-of-io-memory-during-bar-sizing.patch Andi Kleen
2007-10-30 21:41                 ` pci-disable-decode-of-io-memory-during-bar-sizing.patch David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200710301504.36972.jbarnes@virtuousgeek.org \
    --to=jbarnes@virtuousgeek.org \
    --cc=ak@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=arjan@infradead.org \
    --cc=greg@kroah.com \
    --cc=hancockr@shaw.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rajesh.shah@intel.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox