From: Andrew Morton <akpm@linux-foundation.org>
To: Jesper Nilsson <jesper.nilsson@axis.com>
Cc: mikael.starvik@axis.com, jesper.nilsson@axis.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/16] CRIS architecture: Correct compile errors
Date: Tue, 30 Oct 2007 15:14:03 -0700 [thread overview]
Message-ID: <20071030151403.dc43e571.akpm@linux-foundation.org> (raw)
In-Reply-To: <20071030093000.GG11960@axis.com>
On Tue, 30 Oct 2007 10:30:00 +0100
Jesper Nilsson <jesper.nilsson@axis.com> wrote:
>
> Include asm/irq.h to avoid undefined value warning.
>
When fixing build errors or warnings please always always quote the
compiler output so that we can see what you're actually fixing. Saying
"undefined value warning" is pretty useless.
When quoting gcc output, please ensure that LANG=C was set - otherwise gcc
will emit utf gobbledigook which basically never makes it through the
system unscathed.
> diff -urBb -X /h/jespern/.exclude_files clean_linux-2.6.23/include/asm-cris/hardirq.h linux-2.6.23/include/asm-cris/hardirq.h
> --- clean_linux-2.6.23/include/asm-cris/hardirq.h 2007-10-09 22:31:38.000000000 +0200
> +++ linux-2.6.23/include/asm-cris/hardirq.h 2007-10-22 10:35:12.000000000 +0200
> @@ -1,6 +1,7 @@
> #ifndef __ASM_HARDIRQ_H
> #define __ASM_HARDIRQ_H
>
> +#include <asm/irq.h>
> #include <linux/threads.h>
> #include <linux/cache.h>
>
hrm, OK. Not linux/irq.h? I guess not, as cris doesn't appear to support
CONFIG_GENERIC_HARDIRQS.
prev parent reply other threads:[~2007-10-30 22:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-30 9:30 [PATCH 4/16] CRIS architecture: Correct compile errors Jesper Nilsson
2007-10-30 22:14 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071030151403.dc43e571.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=jesper.nilsson@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mikael.starvik@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox