* [PATCH 5/16] CRIS architecture: Correct compile errors
@ 2007-10-30 9:30 Jesper Nilsson
2007-10-30 22:14 ` Andrew Morton
0 siblings, 1 reply; 2+ messages in thread
From: Jesper Nilsson @ 2007-10-30 9:30 UTC (permalink / raw)
To: Andrew Morton, Mikael Starvik, Jesper Nilsson, linux-kernel
Include file linux/compiler.h is needed for 'likely'.
Signed-off-by: Jesper Nilsson <jesper.nilsson@axis.com>
---
atomic.h | 1 +
1 file changed, 1 insertion(+)
diff -urBb -X /h/jespern/.exclude_files clean_linux-2.6.23/include/asm-cris/atomic.h linux-2.6.23/include/asm-cris/atomic.h
--- clean_linux-2.6.23/include/asm-cris/atomic.h 2007-10-09 22:31:38.000000000 +0200
+++ linux-2.6.23/include/asm-cris/atomic.h 2007-10-22 10:32:54.000000000 +0200
@@ -5,6 +5,7 @@
#include <asm/system.h>
#include <asm/arch/atomic.h>
+#include <linux/compiler.h>
/*
* Atomic operations that C can't guarantee us. Useful for
/^JN - Jesper Nilsson
--
Jesper Nilsson -- jesper.nilsson@axis.com
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH 5/16] CRIS architecture: Correct compile errors
2007-10-30 9:30 [PATCH 5/16] CRIS architecture: Correct compile errors Jesper Nilsson
@ 2007-10-30 22:14 ` Andrew Morton
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Morton @ 2007-10-30 22:14 UTC (permalink / raw)
To: Jesper Nilsson; +Cc: mikael.starvik, jesper.nilsson, linux-kernel
On Tue, 30 Oct 2007 10:30:31 +0100
Jesper Nilsson <jesper.nilsson@axis.com> wrote:
> Include file linux/compiler.h is needed for 'likely'.
>
> Signed-off-by: Jesper Nilsson <jesper.nilsson@axis.com>
>
> ---
> atomic.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff -urBb -X /h/jespern/.exclude_files clean_linux-2.6.23/include/asm-cris/atomic.h linux-2.6.23/include/asm-cris/atomic.h
> --- clean_linux-2.6.23/include/asm-cris/atomic.h 2007-10-09 22:31:38.000000000 +0200
> +++ linux-2.6.23/include/asm-cris/atomic.h 2007-10-22 10:32:54.000000000 +0200
> @@ -5,6 +5,7 @@
>
> #include <asm/system.h>
> #include <asm/arch/atomic.h>
> +#include <linux/compiler.h>
>
> /*
> * Atomic operations that C can't guarantee us. Useful for
> /^JN - Jesper Nilsson
> --
We conventionally include the <linux/...> headers before the <asm/...>
headers, with a single blank line between them. So:
#ifndef __ASM_CRIS_ATOMIC__
#define __ASM_CRIS_ATOMIC__
#include <linux/compiler.h>
#include <asm/system.h>
#include <asm/arch/atomic.h>
/*
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-10-30 22:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-30 9:30 [PATCH 5/16] CRIS architecture: Correct compile errors Jesper Nilsson
2007-10-30 22:14 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox