From: Kristof Provost <Kristof@provost-engineering.be>
To: Roel Kluin <12o3l@tiscali.nl>
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] several returns before unlocking in lmc_ioctl
Date: Tue, 30 Oct 2007 19:28:32 +0100 [thread overview]
Message-ID: <20071030182832.GI32270@berith> (raw)
In-Reply-To: <471D52C4.1050701@tiscali.nl>
[-- Attachment #1: Type: text/plain, Size: 889 bytes --]
On 2007-10-23 03:47:48 (+0200), Roel Kluin <12o3l@tiscali.nl> wrote:
> I think we should keep the lmc_tracing. Use this patch instead.
>
> --
> Several returns before unlocking in lmc_ioctl
>
> Signed-off-by: Roel Kluin <12o3l@tiscali.nl>
> ---
> diff --git a/drivers/net/wan/lmc/lmc_main.c b/drivers/net/wan/lmc/lmc_main.c
> index 5ea8772..64eb578 100644
<snip>
> @@ -229,9 +234,10 @@ int lmc_ioctl (struct net_device *dev, struct ifreq *ifr, int cmd) /*fold00*/
> sc->lmc_xinfo.Magic1 = 0xDEADBEEF;
>
> if (copy_to_user(ifr->ifr_data, &sc->lmc_xinfo,
> - sizeof (struct lmc_xinfo)))
> - return -EFAULT;
> - ret = 0;
> + sizeof(struct lmc_xinfo))) {
> + ret = -EFAULT;
> + else
> + ret = 0;
I think you have an extra curly brace there. It breaks compile on my
system.
Kristof
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2007-10-30 18:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-23 0:59 [PATCH] several returns before unlocking in lmc_ioctl Roel Kluin
2007-10-23 1:47 ` Roel Kluin
2007-10-30 18:28 ` Kristof Provost [this message]
2007-10-30 19:15 ` Roel Kluin
2007-10-30 19:50 ` Kristof Provost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071030182832.GI32270@berith \
--to=kristof@provost-engineering.be \
--cc=12o3l@tiscali.nl \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox