From: Andy Whitcroft <apw@shadowen.org>
To: Timur Tabi <timur@freescale.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: checkpatch bug: space between left parenthesis and asterisk
Date: Tue, 30 Oct 2007 21:46:34 +0000 [thread overview]
Message-ID: <20071030214634.GA4574@shadowen.org> (raw)
In-Reply-To: <47278591.90305@freescale.com>
On Tue, Oct 30, 2007 at 02:27:13PM -0500, Timur Tabi wrote:
> I'm running checkpatch.pl (dated 10/17), and it complains about this line:
>
> crc = __be32_to_cpu(* ((__be32 *) ((void *) firmware + calc_size)));
>
> the message I get is:
>
> ERROR: need space before that '*' (ctx:BxW)
> #721: FILE: arch/powerpc/sysdev/qe_lib/qe.c:527:
> + crc = __be32_to_cpu(* ((__be32 *) ((void *) firmware + calc_size)));
Hmmm, i've looked back a couple of releases and this seems to get
reported correctly. Removing this space is then silent.
ERROR: no space after that '*' (ctx:BxW)
#4: FILE: Z31.c:1:
+ crc = __be32_to_cpu(* ((__be32 *) ((void *) firmware + calc_size)));
What version is checkpatch reported as? Also can I have the entire diff
hunk this is from in case its being caused by the context, though that
seems unlikely.
Thanks.
-apw
prev parent reply other threads:[~2007-10-30 21:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-30 19:27 checkpatch bug: space between left parenthesis and asterisk Timur Tabi
2007-10-30 19:54 ` Zach Brown
2007-10-30 20:02 ` Timur Tabi
2007-10-30 21:46 ` Andy Whitcroft [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071030214634.GA4574@shadowen.org \
--to=apw@shadowen.org \
--cc=linux-kernel@vger.kernel.org \
--cc=timur@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox