* [PATCH] acpi: 'acpi_gbl_system_awake_and_running' is no longer used, only assigned.
@ 2007-10-30 10:54 Richard Knutsson
2007-10-31 2:33 ` Len Brown
0 siblings, 1 reply; 2+ messages in thread
From: Richard Knutsson @ 2007-10-30 10:54 UTC (permalink / raw)
To: len.brown; +Cc: linux-acpi, linux-kernel, Richard Knutsson
'acpi_gbl_system_awake_and_running' is no longer used, only assigned.
Signed-off-by: Richard Knutsson <ricknu-0@student.ltu.se>
---
Diffed against linus-git
Checked with script/checkpatch.pl
drivers/acpi/hardware/hwsleep.c | 5 -----
drivers/acpi/utilities/utglobal.c | 1 -
include/acpi/acglobal.h | 1 -
3 files changed, 7 deletions(-)
diff --git a/drivers/acpi/hardware/hwsleep.c b/drivers/acpi/hardware/hwsleep.c
index 81b2484..e020e50 100644
--- a/drivers/acpi/hardware/hwsleep.c
+++ b/drivers/acpi/hardware/hwsleep.c
@@ -300,8 +300,6 @@ acpi_status asmlinkage acpi_enter_sleep_state(u8 sleep_state)
return_ACPI_STATUS(status);
}
- acpi_gbl_system_awake_and_running = FALSE;
-
status = acpi_hw_enable_all_wakeup_gpes();
if (ACPI_FAILURE(status)) {
return_ACPI_STATUS(status);
@@ -446,7 +444,6 @@ acpi_status asmlinkage acpi_enter_sleep_state_s4bios(void)
if (ACPI_FAILURE(status)) {
return_ACPI_STATUS(status);
}
- acpi_gbl_system_awake_and_running = FALSE;
status = acpi_hw_enable_all_wakeup_gpes();
if (ACPI_FAILURE(status)) {
@@ -587,8 +584,6 @@ acpi_status acpi_leave_sleep_state(u8 sleep_state)
}
/* TBD: _WAK "sometimes" returns stuff - do we want to look at it? */
- acpi_gbl_system_awake_and_running = TRUE;
-
/* Enable power button */
(void)
diff --git a/drivers/acpi/utilities/utglobal.c b/drivers/acpi/utilities/utglobal.c
index 93ea829..f2ba315 100644
--- a/drivers/acpi/utilities/utglobal.c
+++ b/drivers/acpi/utilities/utglobal.c
@@ -709,7 +709,6 @@ void acpi_ut_init_globals(void)
/* Hardware oriented */
acpi_gbl_events_initialized = FALSE;
- acpi_gbl_system_awake_and_running = TRUE;
/* Namespace */
diff --git a/include/acpi/acglobal.h b/include/acpi/acglobal.h
index 347a911..ae0fc0a 100644
--- a/include/acpi/acglobal.h
+++ b/include/acpi/acglobal.h
@@ -236,7 +236,6 @@ ACPI_EXTERN u8 acpi_gbl_step_to_next_call;
ACPI_EXTERN u8 acpi_gbl_acpi_hardware_present;
ACPI_EXTERN u8 acpi_gbl_global_lock_present;
ACPI_EXTERN u8 acpi_gbl_events_initialized;
-ACPI_EXTERN u8 acpi_gbl_system_awake_and_running;
extern u8 acpi_gbl_shutdown;
extern u32 acpi_gbl_startup_flags;
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] acpi: 'acpi_gbl_system_awake_and_running' is no longer used, only assigned.
2007-10-30 10:54 [PATCH] acpi: 'acpi_gbl_system_awake_and_running' is no longer used, only assigned Richard Knutsson
@ 2007-10-31 2:33 ` Len Brown
0 siblings, 0 replies; 2+ messages in thread
From: Len Brown @ 2007-10-31 2:33 UTC (permalink / raw)
To: Richard Knutsson; +Cc: linux-acpi, linux-kernel
Bob reports that this is used in a pending version of ACPICA,
so we'll leave the code alone.
thanks,
-Len
On Tuesday 30 October 2007 06:54, Richard Knutsson wrote:
> 'acpi_gbl_system_awake_and_running' is no longer used, only assigned.
>
> Signed-off-by: Richard Knutsson <ricknu-0@student.ltu.se>
> ---
> Diffed against linus-git
> Checked with script/checkpatch.pl
>
> drivers/acpi/hardware/hwsleep.c | 5 -----
> drivers/acpi/utilities/utglobal.c | 1 -
> include/acpi/acglobal.h | 1 -
> 3 files changed, 7 deletions(-)
>
>
> diff --git a/drivers/acpi/hardware/hwsleep.c b/drivers/acpi/hardware/hwsleep.c
> index 81b2484..e020e50 100644
> --- a/drivers/acpi/hardware/hwsleep.c
> +++ b/drivers/acpi/hardware/hwsleep.c
> @@ -300,8 +300,6 @@ acpi_status asmlinkage acpi_enter_sleep_state(u8 sleep_state)
> return_ACPI_STATUS(status);
> }
>
> - acpi_gbl_system_awake_and_running = FALSE;
> -
> status = acpi_hw_enable_all_wakeup_gpes();
> if (ACPI_FAILURE(status)) {
> return_ACPI_STATUS(status);
> @@ -446,7 +444,6 @@ acpi_status asmlinkage acpi_enter_sleep_state_s4bios(void)
> if (ACPI_FAILURE(status)) {
> return_ACPI_STATUS(status);
> }
> - acpi_gbl_system_awake_and_running = FALSE;
>
> status = acpi_hw_enable_all_wakeup_gpes();
> if (ACPI_FAILURE(status)) {
> @@ -587,8 +584,6 @@ acpi_status acpi_leave_sleep_state(u8 sleep_state)
> }
> /* TBD: _WAK "sometimes" returns stuff - do we want to look at it? */
>
> - acpi_gbl_system_awake_and_running = TRUE;
> -
> /* Enable power button */
>
> (void)
> diff --git a/drivers/acpi/utilities/utglobal.c b/drivers/acpi/utilities/utglobal.c
> index 93ea829..f2ba315 100644
> --- a/drivers/acpi/utilities/utglobal.c
> +++ b/drivers/acpi/utilities/utglobal.c
> @@ -709,7 +709,6 @@ void acpi_ut_init_globals(void)
> /* Hardware oriented */
>
> acpi_gbl_events_initialized = FALSE;
> - acpi_gbl_system_awake_and_running = TRUE;
>
> /* Namespace */
>
> diff --git a/include/acpi/acglobal.h b/include/acpi/acglobal.h
> index 347a911..ae0fc0a 100644
> --- a/include/acpi/acglobal.h
> +++ b/include/acpi/acglobal.h
> @@ -236,7 +236,6 @@ ACPI_EXTERN u8 acpi_gbl_step_to_next_call;
> ACPI_EXTERN u8 acpi_gbl_acpi_hardware_present;
> ACPI_EXTERN u8 acpi_gbl_global_lock_present;
> ACPI_EXTERN u8 acpi_gbl_events_initialized;
> -ACPI_EXTERN u8 acpi_gbl_system_awake_and_running;
>
> extern u8 acpi_gbl_shutdown;
> extern u32 acpi_gbl_startup_flags;
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-10-31 2:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-30 10:54 [PATCH] acpi: 'acpi_gbl_system_awake_and_running' is no longer used, only assigned Richard Knutsson
2007-10-31 2:33 ` Len Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).