From: Ingo Molnar <mingo@elte.hu>
To: Christoph Hellwig <hch@infradead.org>
Cc: Andi Kleen <andi@firstfloor.org>,
Steven Rostedt <rostedt@goodmis.org>,
LKML <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Daniel Walker <dwalker@mvista.com>
Subject: Re: [PATCH] dump_stack on panic
Date: Wed, 31 Oct 2007 11:17:46 +0100 [thread overview]
Message-ID: <20071031101746.GC5817@elte.hu> (raw)
In-Reply-To: <20071031081513.GB3810@infradead.org>
* Christoph Hellwig <hch@infradead.org> wrote:
> On Wed, Oct 31, 2007 at 01:14:04AM +0100, Andi Kleen wrote:
> > One (mostly psychological, but still serious) problem is that stack
> > dumps make panics always look like kernel bugs. But there are panics
> > which are definitely not kernel bugs: like the popular cannot mount
> > root or machine checks or a couple of others.
>
> But that one really shouldn't be a panic anyway. The panic alone is
> psycologically bad enough for users. I think it would be best to have
> a simple scanf loop asking for another root device..
yep. Steve's patch looks good in any case.
Acked-by: Ingo Molnar <mingo@elte.hu>
Ingo
next prev parent reply other threads:[~2007-10-31 10:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-31 0:02 [PATCH] dump_stack on panic Steven Rostedt
2007-10-31 0:14 ` Andi Kleen
2007-10-31 0:30 ` Steven Rostedt
2007-10-31 8:15 ` Christoph Hellwig
2007-10-31 10:17 ` Ingo Molnar [this message]
2007-10-31 10:41 ` Andi Kleen
2007-10-31 10:58 ` Steven Rostedt
2007-10-31 11:17 ` Andi Kleen
2007-10-31 11:39 ` Steven Rostedt
2007-10-31 11:53 ` Andi Kleen
2007-10-31 14:19 ` Arjan van de Ven
2007-10-31 15:00 ` Steven Rostedt
2007-10-31 16:28 ` Arjan van de Ven
2007-10-31 16:39 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071031101746.GC5817@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=dwalker@mvista.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox