From: Jesper Nilsson <jesper.nilsson@axis.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: mikael.starvik@axis.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/16] CRIS architecture: Correct compile errors
Date: Wed, 31 Oct 2007 11:55:53 +0100 [thread overview]
Message-ID: <20071031105552.GX11960@axis.com> (raw)
In-Reply-To: <20071031104738.GW11960@axis.com>
On Wed, Oct 31, 2007 at 11:47:38AM +0100, Jesper Nilsson wrote:
> On Tue, Oct 30, 2007 at 03:14:00PM -0700, Andrew Morton wrote:
> > On Tue, 30 Oct 2007 10:28:11 +0100
> > Jesper Nilsson <jesper.nilsson@axis.com> wrote:
> > > Remove include of asm/bitops.h, not needed here, corrects compilation error
> > > (__le64 undefined).
> > [snip]
> >
> > This doesn't apply and I'm not sure that it is still needed or correct.
> >
> > I'll drop it.
>
> Unfortunately it is still needed, I'll resend a fresh patch
> against Linus git tree.
>
> Compile error:
>
> CC arch/cris/kernel/asm-offsets.s
> In file included from include/asm/byteorder.h:23,
> from include/asm-generic/bitops/le.h:5,
> from include/asm-generic/bitops/ext2-non-atomic.h:4,
> from include/asm/bitops.h:163,
> from include/linux/bitops.h:17,
> from include/asm/posix_types.h:55,
> from include/linux/posix_types.h:47,
> from include/linux/types.h:11,
> from include/linux/capability.h:16,
> from include/linux/sched.h:49,
> from arch/cris/kernel/asm-offsets.c:1:
> include/linux/byteorder/little_endian.h:43: parse error before "__cpu_to_le64p"
> include/linux/byteorder/little_endian.h:44: warning: return type defaults to `int'
> include/linux/byteorder/little_endian.h: In function `__cpu_to_le64p':
> include/linux/byteorder/little_endian.h:45: `__le64' undeclared (first use in this function)
> ....
Remove include of asm/bitops.h, not needed here, corrects compilation error
(__le64 undeclared).
Signed-off-by: Jesper Nilsson <jesper.nilsson@axis.com>
---
posix_types.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/include/asm-cris/posix_types.h b/include/asm-cris/posix_types.h
index 92000d0..3a5e4c4 100644
--- a/include/asm-cris/posix_types.h
+++ b/include/asm-cris/posix_types.h
@@ -52,7 +52,6 @@ typedef struct {
} __kernel_fsid_t;
#ifdef __KERNEL__
-#include <linux/bitops.h>
#undef __FD_SET
#define __FD_SET(fd,fdsetp) set_bit(fd, (void *)(fdsetp))
/^JN - Jesper Nilsson
--
Jesper Nilsson -- jesper.nilsson@axis.com
prev parent reply other threads:[~2007-10-31 10:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-30 9:28 [PATCH 1/16] CRIS architecture: Correct compile errors Jesper Nilsson
2007-10-30 22:14 ` Andrew Morton
2007-10-31 10:47 ` Jesper Nilsson
2007-10-31 10:55 ` Jesper Nilsson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071031105552.GX11960@axis.com \
--to=jesper.nilsson@axis.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikael.starvik@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).